Fair Return Types #2336
Open
Fair Return Types #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 9, 2023
|
@AndreyAkinshin I moved this to v0.14.0 milestone because I think both #2334 and this should go out in the same version so that we are only affecting measurement accuracy in a single version, rather than multiple versions. If we can't get them both in v0.14.0, let's push them both out. |
tests/BenchmarkDotNet.IntegrationTests.ManualRunning/ExpectedBenchmarkResultsTests.cs
Outdated
Show resolved
Hide resolved
timcassell
force-pushed
the
fair-types
branch
2 times, most recently
from
48266cd
to
4abbb1f
Compare
Overhead always returns `void`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2334. Fixes #2305.
All return types are treated equally. No more special consume logic for
ByRef, orstructreturn types. Return values are popped off the stack instead of passed toConsumeror aNoInliningmethod. This is able to be done while avoiding dead code elimination by taking advantage of the changes made in #2334.Overhead return type is always
voidnow for a fair baseline.Also fixed pointer returns in
InProcessEmitToolchain.