-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate install instructions away from curl ... | bash
type script
#88
Conversation
We're moving away from that, so we'll just ditch it
curl ... | bash
type scriptcurl ... | bash
type script
@binaryannie You mentioned that you were down to help review / test this. If you're still down to help out, I'd appreciate it a whole lot. I'm not quite sure if you're going to be able to start a review yourself tho. Let me know if there are issues. |
I tested with Ubuntu in docker. Everything works fine except two things:
|
I've tested the pre-packaged binary install on alpine in docker. Everything worked but I got a few quirks:
|
Tested install from source on alpine. Didn't work at all. Can't install rust from After that I tested with debian. Worked fine. Got the following quirks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-Authored-By: Annie-Claude Morin <[email protected]>
Co-Authored-By: Annie-Claude Morin <[email protected]>
Co-Authored-By: Annie-Claude Morin <[email protected]>
@binaryannie about the uninstall instructions, that's a good question. For homebrew, linuxbrew & deb, I don't think that there's a point as they have standard uninstall methods and I think that it's fair to consider that users know how to user them or can figure that out. As for the manual installations, I think that it could be useful. I would kick off another PR for that as this PR can stand on its own without uninstall instructions. |
@dotboris I have a hard time testing the install instructions because I already have alt installed and don't know how to uninstall it properly, haha! |
@binaryannie I assume that you have installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: add to changelog
Related to #42 & #41