Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate install instructions away from curl ... | bash type script #88

Merged
merged 26 commits into from
Oct 27, 2019

Conversation

dotboris
Copy link
Owner

@dotboris dotboris commented Sep 3, 2019

Related to #42 & #41

@dotboris dotboris changed the title WIP: Migration install instructions away from curl ... | bash type script Migrate install instructions away from curl ... | bash type script Sep 4, 2019
@dotboris
Copy link
Owner Author

dotboris commented Sep 4, 2019

@binaryannie You mentioned that you were down to help review / test this. If you're still down to help out, I'd appreciate it a whole lot.

I'm not quite sure if you're going to be able to start a review yourself tho. Let me know if there are issues.

README.md Outdated Show resolved Hide resolved
@dotboris
Copy link
Owner Author

dotboris commented Sep 4, 2019

I tested with Ubuntu in docker. Everything works fine except two things:

  1. The comment I left above about apt install ./...
  2. zsh on doesn't source /etc/profile on ubuntu. This should not be a big issue since users will be directed to the troubleshooting section and will solve their issue in the end.

@dotboris
Copy link
Owner Author

dotboris commented Sep 4, 2019

I've tested the pre-packaged binary install on alpine in docker. Everything worked but I got a few quirks:

  1. bash_completion is installed in /usr/share/bash-completion/completions/ so I've had to tweak the path. This is fine because the instructions state that you may need to fix up paths.

@dotboris
Copy link
Owner Author

dotboris commented Sep 4, 2019

Tested install from source on alpine. Didn't work at all. Can't install rust from rustup.rs on alpine. They don't have a musl based version of rustup-init.

After that I tested with debian. Worked fine. Got the following quirks

  1. /etc/bash_completion.d didn't exist so I had to create it myself. This turns out is what I could have done with the prepackaged binary install. I don't think that it's a problem since we expect users to adapt the path, plus it should exist on systems with a bunch of completions already installed
  2. zsh didn't source /etc/profile. This is the same as before. Should be fine.

Copy link
Contributor

@binaryannie binaryannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotboris I see in #42 that you stated

There's no easy / official uninstall method

Is there a way now? Should it be documented here?

EDIT: darn, did not want to end the review here...

src/checks.rs Outdated Show resolved Hide resolved
src/checks.rs Outdated Show resolved Hide resolved
src/checks.rs Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
dotboris and others added 2 commits September 29, 2019 15:46
Co-Authored-By: Annie-Claude Morin <[email protected]>
Co-Authored-By: Annie-Claude Morin <[email protected]>
Co-Authored-By: Annie-Claude Morin <[email protected]>
@dotboris
Copy link
Owner Author

@binaryannie about the uninstall instructions, that's a good question.

For homebrew, linuxbrew & deb, I don't think that there's a point as they have standard uninstall methods and I think that it's fair to consider that users know how to user them or can figure that out.

As for the manual installations, I think that it could be useful. I would kick off another PR for that as this PR can stand on its own without uninstall instructions.

@binaryannie
Copy link
Contributor

binaryannie commented Oct 3, 2019

@dotboris I have a hard time testing the install instructions because I already have alt installed and don't know how to uninstall it properly, haha!

@dotboris
Copy link
Owner Author

dotboris commented Oct 6, 2019

@binaryannie I assume that you have installed alt with the "old" curl ... | bash method. To uninstall alt all you need to do is remove /usr/local/bin/alt.

Copy link
Owner Author

@dotboris dotboris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: add to changelog

@dotboris dotboris merged commit 9b47a05 into master Oct 27, 2019
@dotboris dotboris deleted the new-scriptless-deployment branch April 11, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants