Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(edit-content): Issues with n-1 relationship #31103

Merged
merged 6 commits into from
Jan 10, 2025

Conversation

nicobytes
Copy link
Contributor

@nicobytes nicobytes commented Jan 10, 2025

Proposed Changes

This pull request includes several changes to the dot-edit-content-relationship-field component and its associated utilities. The most important changes include removing an unimplemented command, adding detailed documentation for relationship options, updating test cases to cover additional scenarios, and modifying the logic for determining selection mode based on relationship type.

Codebase simplification:

Documentation improvements:

Test coverage enhancements:

Logic updates:

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

This PR fixes: #31040

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@nicobytes nicobytes requested a review from hmoreras January 10, 2025 17:45
@nicobytes nicobytes enabled auto-merge January 10, 2025 17:45
@nicobytes nicobytes disabled auto-merge January 10, 2025 18:00
@nicobytes nicobytes enabled auto-merge January 10, 2025 18:44
@nicobytes nicobytes requested a review from Copilot January 10, 2025 18:44

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/dot-select-existing-content.component.html: Language not supported
  • core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.html: Language not supported
  • core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/dot-select-existing-content.component.ts: Evaluated as low risk
  • core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/utils/index.spec.ts: Evaluated as low risk
  • core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/store/relationship-field.store.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)

core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/utils/index.ts:16

  • The error message should be more descriptive. Consider changing it to: Invalid relationship type for cardinality value: ${cardinality}. Expected values are 0, 1, 2, or 3.
throw new Error(`Invalid relationship type for cardinality: ${cardinality}`);
@nicobytes nicobytes added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 85dab88 Jan 10, 2025
22 checks passed
@nicobytes nicobytes deleted the 31040-issues-n-1-relationship branch January 10, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save and show relationships
3 participants