Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(edit-content): apply format to relationships #31048

Merged
merged 11 commits into from
Jan 3, 2025

Conversation

nicobytes
Copy link
Contributor

@nicobytes nicobytes commented Jan 3, 2025

Parent Issue

#31040

Proposed Changes

This pull request introduces a new enumeration DotContentletDepths to manage the depth of contentlets and updates various components to utilize this enumeration. The changes include updates to type definitions, imports, and method calls to incorporate the new DotContentletDepths enum.

Introduction of DotContentletDepths Enumeration:

  • Added DotContentletDepths enum to define the depth levels of contentlets in dot-contentlet.model.ts.

Updates to Import Statements:

  • Updated import statements to include DotContentletDepths in dot-edit-content-form.component.spec.ts, edit-content.store.ts, content.feature.ts, dot-edit-content-relationship-field.component.ts, dot-edit-content.service.spec.ts, and dot-edit-content.service.ts. [1] [2] [3] [4] [5]

Updates to Method Calls:

  • Modified initializeExistingContent method calls to include the depth parameter in dot-edit-content-form.component.spec.ts and edit-content.store.ts. [1] [2] [3] [4] [5] [6] [7]

Enhancements to Relationship Field Store:

  • Added a new test file relationship-field.store.spec.ts to validate the functionality of RelationshipFieldStore.
  • Enhanced relationship-field.store.ts by adding computed properties for pagination, disabling create new content button, and formatting relationships. Removed unnecessary hooks and methods. [1] [2] [3] [4] [5]

Service Method Updates:

  • Updated dot-edit-content.service.spec.ts to include a test for getting content by id and depth.

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

This PR fixes: #31040

@nicobytes nicobytes linked an issue Jan 3, 2025 that may be closed by this pull request
@nicobytes nicobytes requested a review from Copilot January 3, 2025 16:35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • core-web/libs/edit-content/src/lib/feature/edit-content/store/features/content.feature.ts: Evaluated as low risk
  • core-web/libs/edit-content/src/lib/services/dot-edit-content.service.ts: Evaluated as low risk
  • core-web/libs/edit-content/src/lib/feature/edit-content/store/edit-content.store.ts: Evaluated as low risk
@nicobytes nicobytes marked this pull request as ready for review January 3, 2025 19:56

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (7)
  • core-web/libs/edit-content/src/lib/fields/dot-edit-content-file-field/services/upload-file/upload-file.service.ts: Evaluated as low risk
  • core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.ts: Evaluated as low risk
  • core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/store/relationship-field.store.spec.ts: Evaluated as low risk
  • core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/store/relationship-field.store.ts: Evaluated as low risk
  • core-web/libs/edit-content/src/lib/services/dot-edit-content.service.spec.ts: Evaluated as low risk
  • core-web/libs/edit-content/src/lib/services/dot-edit-content.service.ts: Evaluated as low risk
  • core-web/libs/edit-content/src/lib/feature/edit-content/store/features/content.feature.ts: Evaluated as low risk
@nicobytes nicobytes enabled auto-merge January 3, 2025 21:18
@nicobytes nicobytes added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit e0b5efc Jan 3, 2025
22 checks passed
@nicobytes nicobytes deleted the 31040-save-relationships branch January 3, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save and show relationships
3 participants