-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(edit-content): apply format to relationships #31048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (3)
- core-web/libs/edit-content/src/lib/feature/edit-content/store/features/content.feature.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/services/dot-edit-content.service.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/feature/edit-content/store/edit-content.store.ts: Evaluated as low risk
core-web/libs/edit-content/src/lib/services/dot-edit-content.service.ts
Outdated
Show resolved
Hide resolved
core-web/libs/edit-content/src/lib/feature/edit-content/store/features/content.feature.ts
Outdated
Show resolved
Hide resolved
…o 31040-save-relationships
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (7)
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-file-field/services/upload-file/upload-file.service.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/store/relationship-field.store.spec.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/store/relationship-field.store.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/services/dot-edit-content.service.spec.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/services/dot-edit-content.service.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/feature/edit-content/store/features/content.feature.ts: Evaluated as low risk
Parent Issue
#31040
Proposed Changes
This pull request introduces a new enumeration
DotContentletDepths
to manage the depth of contentlets and updates various components to utilize this enumeration. The changes include updates to type definitions, imports, and method calls to incorporate the newDotContentletDepths
enum.Introduction of
DotContentletDepths
Enumeration:DotContentletDepths
enum to define the depth levels of contentlets indot-contentlet.model.ts
.Updates to Import Statements:
DotContentletDepths
indot-edit-content-form.component.spec.ts
,edit-content.store.ts
,content.feature.ts
,dot-edit-content-relationship-field.component.ts
,dot-edit-content.service.spec.ts
, anddot-edit-content.service.ts
. [1] [2] [3] [4] [5]Updates to Method Calls:
initializeExistingContent
method calls to include thedepth
parameter indot-edit-content-form.component.spec.ts
andedit-content.store.ts
. [1] [2] [3] [4] [5] [6] [7]Enhancements to Relationship Field Store:
relationship-field.store.spec.ts
to validate the functionality ofRelationshipFieldStore
.relationship-field.store.ts
by adding computed properties for pagination, disabling create new content button, and formatting relationships. Removed unnecessary hooks and methods. [1] [2] [3] [4] [5]Service Method Updates:
dot-edit-content.service.spec.ts
to include a test for getting content by id and depth.Checklist
This PR fixes: #31040