-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(edit-content): Show restrictions based on the relationship. #30976
Merged
nicobytes
merged 15 commits into
main
from
30928-relationship-field-allow-choosing-content-according-to-the-relationship
Dec 27, 2024
Merged
feat(edit-content): Show restrictions based on the relationship. #30976
nicobytes
merged 15 commits into
main
from
30928-relationship-field-allow-choosing-content-according-to-the-relationship
Dec 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent-according-to-the-relationship
…ent-according-to-the-relationship
…ent-according-to-the-relationship
nicobytes
changed the title
chore(edit-content): handle 1-1 with radio button
feat(edit-content): Show restrictions based on the relationship.
Dec 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (10)
- core-web/libs/dotcms-scss/angular/dotcms-theme/components/form/_radiobutton.scss: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/dot-select-existing-content.component.html: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/header/header.component.html: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.html: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.scss: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-file-field/components/dot-select-existing-file/dot-select-existing-file.component.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/store/existing-content.store.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/dot-select-existing-content.component.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/store/relationship-field.store.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.constants.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.ts:229
- Ensure there is a test case that verifies
selectionMode
is correctly set before callingshowExistingContentDialog
.
selectionMode: this.store.selectionMode()
…ent-according-to-the-relationship
…ent-according-to-the-relationship
…ng-to-the-relationship' of github.com:dotCMS/core into 30928-relationship-field-allow-choosing-content-according-to-the-relationship
…ent-according-to-the-relationship
rjvelazco
approved these changes
Dec 27, 2024
.../fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.ts
Show resolved
Hide resolved
.../fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.ts
Show resolved
Hide resolved
...ields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.html
Show resolved
Hide resolved
...dit-content/src/lib/fields/dot-edit-content-relationship-field/models/relationship.models.ts
Show resolved
Hide resolved
KevinDavilaDotCMS
approved these changes
Dec 27, 2024
nicobytes
deleted the
30928-relationship-field-allow-choosing-content-according-to-the-relationship
branch
December 27, 2024 18:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent Issue
#30928
Proposed Changes
This pull request includes several changes to improve the functionality and maintainability of the
dot-select-existing-content
component and its associated files. The most important changes include enhancements to the selection mode, updates to the dialog behavior, and improvements to the component's initialization and testing.Enhancements to selection mode:
dot-select-existing-content.component.html
file, allowing for both multiple and single selection modes. [1] [2] [3] [4] [5] [6]Updates to dialog behavior:
dot-select-existing-content.component.ts
to include theDynamicDialogConfig
andDynamicDialogRef
services for better dialog management. [1] [2] [3] [4]dot-select-existing-content.component.spec.ts
to include tests for dialog initialization, closing behavior, and selection mode validation. [1] [2] [3] [4] [5]Improvements to initialization and testing:
dot-select-existing-content.component.ts
to ensure the component starts with the correct configuration.dot-select-existing-content.component.spec.ts
to cover various scenarios, including initialization, dialog behavior, and item selection. [1] [2] [3] [4] [5]Minor adjustments:
_radiobutton.scss
to include a new class for styling radio buttons.dot-select-existing-file.component.ts
to improve code readability and maintainability. [1] [2]Checklist
This PR fixes: #30928