Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#30694 switching from ISO to UTF-8 #30953

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

#30694 switching from ISO to UTF-8 #30953

wants to merge 2 commits into from

Conversation

jdotcms
Copy link
Contributor

@jdotcms jdotcms commented Dec 16, 2024

Switching the charset to UTF-8 is a wider group of languages would be supported

@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Open
fabrizzio-dotCMS
fabrizzio-dotCMS reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@fabrizzio-dotCMS fabrizzio-dotCMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend you do a migration test

@jdotcms jdotcms enabled auto-merge December 17, 2024 22:06
@jdotcms
Copy link
Contributor Author

jdotcms commented Dec 17, 2024 •
edited
Loading

I recommend you do a migration test

didnt you create a test for the UT? @fabrizzio-dotCMS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabrizzio-dotCMS fabrizzio-dotCMS fabrizzio-dotCMS left review comments

@victoralfaro-dotcms victoralfaro-dotcms victoralfaro-dotcms approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdotcms @fabrizzio-dotCMS @victoralfaro-dotcms