Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TimeMachine) include FTM content as rendered html Refs: #30937 #30952

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

fabrizzio-dotCMS
Copy link
Contributor

@fabrizzio-dotCMS fabrizzio-dotCMS commented Dec 16, 2024

Proposed Changes

This update resolves an issue where changes related to TimeMachineDate were not reflected in the Rendered field, which generates the HTML output. Previously, the Contentlets field responded to these changes, but the same functionality was not applied to the Rendered field.

The update introduces two key improvements:

The TimeMachineDate is now passed to the same function used to process Contentlets, ensuring that changes also affect the Rendered field.

This function handles validation of contentlets, checking if they are scheduled for future publication or if their validity has expired. This ensures consistent behavior across fields.

The VTL layer contained logic for handling TimeMachine, which is now obsolete. All necessary validation is centralized within the updated function.

This PR fixes: #30937

@fabrizzio-dotCMS fabrizzio-dotCMS marked this pull request as ready for review December 18, 2024 19:04
@fabrizzio-dotCMS fabrizzio-dotCMS added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 5340ecd Dec 18, 2024
36 checks passed
@fabrizzio-dotCMS fabrizzio-dotCMS deleted the issue-30937-tm-render-content branch December 18, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FTM: PageApi rendered response dont show future contenlets
3 participants