Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#30820 Create Custom Hook for Page View Content Analytics Integration #30922

Merged
merged 19 commits into from
Dec 19, 2024
Merged

#30820 Create Custom Hook for Page View Content Analytics Integration #30922

merged 19 commits into from
Dec 19, 2024

Conversation

oidacra
Copy link
Member

@oidacra oidacra commented Dec 11, 2024 •
edited by github-actions bot
Loading

Proposed Changes

  • Add Providers, Custom Hooks to consume DotContentAnalytics

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Additional Info

** any additional useful context or info **

Screenshots

Pageview + Custom Track Event
https://github.com/user-attachments/assets/e4ab4554-70bd-4d52-abde-38dddad3be49

This PR fixes: #30820

@oidacra oidacra linked an issue Dec 11, 2024 that may be closed by this pull request
Create Custom Hook for Page View Content Analytics Integration #30820
Closed
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Closed
@oidacra oidacra changed the title #30820 Add Providers, Custom Hooks to consume DotContentAnalytics #30820 Create Custom Hook for Page View Content Analytics Integration Dec 11, 2024
fmontes
fmontes previously requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@fmontes fmontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More in the Slack convo.

core-web/libs/sdk/analytics/README.md Outdated Show resolved Hide resolved
core-web/libs/sdk/analytics/src/lib/react/components/DotContentAnalyticsProvider.tsx Outdated Show resolved Hide resolved
core-web/libs/sdk/analytics/src/index.ts Outdated Show resolved Hide resolved
core-web/libs/sdk/analytics/src/lib/plugin/dot-analytics.plugin.ts Outdated Show resolved Hide resolved
core-web/libs/sdk/analytics/src/lib/plugin/dot-analytics.plugin.ts Outdated Show resolved Hide resolved
examples/nextjs/src/components/my-page.js Outdated Show resolved Hide resolved
@oidacra oidacra force-pushed the 30820-custom-hook-content-analytics-sdk branch from 7b219ea to e415487 Compare December 13, 2024 21:10
@oidacra oidacra dismissed stale reviews from fmontes and nicobytes December 13, 2024 21:11

Done.

@oidacra oidacra requested a review from nicobytes December 13, 2024 21:12
@oidacra oidacra force-pushed the 30820-custom-hook-content-analytics-sdk branch from 22850c5 to 9d616de Compare December 17, 2024 04:27
@oidacra oidacra marked this pull request as ready for review December 17, 2024 04:28
@semgrep-code-dotcms-test
Copy link

Semgrep found 1 ssc-cee3e6d5-d7c8-4c35-9815-076aa1ebfd49 finding:

Risk: Affected versions of rollup are vulnerable to Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting').

Manual Review Advice: A vulnerability from this advisory is reachable if you use Rollup to bundle JavaScript with import.meta.url and the output format is set to cjs, umd, or iife formats, while allowing users to inject scriptless HTML elements with unsanitized name attributes

Fix: Upgrade this library to at least version 4.22.4 at core/core-web/yarn.lock:20358.

Reference(s): GHSA-gcx4-mw62-g8wm, CVE-2024-47068

Ignore this finding from ssc-cee3e6d5-d7c8-4c35-9815-076aa1ebfd49

@oidacra oidacra force-pushed the 30820-custom-hook-content-analytics-sdk branch from 527546c to 5cf2435 Compare December 17, 2024 18:55
@semgrep-code-dotcms-test
Copy link

Semgrep found 1 ssc-cee3e6d5-d7c8-4c35-9815-076aa1ebfd49 finding:

Risk: Affected versions of rollup are vulnerable to Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting').

Manual Review Advice: A vulnerability from this advisory is reachable if you use Rollup to bundle JavaScript with import.meta.url and the output format is set to cjs, umd, or iife formats, while allowing users to inject scriptless HTML elements with unsanitized name attributes

Fix: Upgrade this library to at least version 4.22.4 at core/core-web/yarn.lock:20283.

Reference(s): GHSA-gcx4-mw62-g8wm, CVE-2024-47068

Ignore this finding from ssc-cee3e6d5-d7c8-4c35-9815-076aa1ebfd49.

@oidacra oidacra force-pushed the 30820-custom-hook-content-analytics-sdk branch from d62a1b8 to 5cf2435 Compare December 17, 2024 20:48
fmontes
fmontes previously requested changes Dec 18, 2024
View reviewed changes
core-web/libs/sdk/analytics/src/lib/react/hook/useContentAnalytics.ts Show resolved Hide resolved
core-web/libs/sdk/analytics/src/lib/react/components/DotContentAnalyticsProvider.tsx Outdated Show resolved Hide resolved
core-web/libs/sdk/analytics/src/lib/react/hook/useRouterTracker.ts Show resolved Hide resolved
core-web/libs/sdk/analytics/src/lib/react/components/DotContentAnalyticsProvider.tsx Outdated Show resolved Hide resolved
core-web/libs/sdk/analytics/src/lib/react/hook/useContentAnalytics.ts Outdated Show resolved Hide resolved
examples/nextjs/src/components/content-types/activity.js Outdated Show resolved Hide resolved
examples/nextjs/src/components/content-types/callToAction.js Outdated Show resolved Hide resolved
examples/nextjs/package.json Outdated Show resolved Hide resolved
examples/nextjs/src/components/my-page.js Show resolved Hide resolved
@oidacra oidacra force-pushed the 30820-custom-hook-content-analytics-sdk branch from ea2aa1c to a98e606 Compare December 18, 2024 18:21
@oidacra oidacra requested a review from fmontes December 19, 2024 05:53
@oidacra oidacra dismissed fmontes’s stale review December 19, 2024 05:53

Comments fixed.

@oidacra oidacra force-pushed the 30820-custom-hook-content-analytics-sdk branch from ddda9a3 to f083b0a Compare December 19, 2024 19:16
@oidacra oidacra enabled auto-merge December 19, 2024 19:16
@oidacra oidacra added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 2f636df Dec 19, 2024
22 checks passed
@oidacra oidacra deleted the 30820-custom-hook-content-analytics-sdk branch December 19, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmoreras hmoreras hmoreras approved these changes

@nicobytes nicobytes nicobytes approved these changes

@zJaaal zJaaal Awaiting requested review from zJaaal

@rjvelazco rjvelazco Awaiting requested review from rjvelazco

@KevinDavilaDotCMS KevinDavilaDotCMS Awaiting requested review from KevinDavilaDotCMS

@fmontes fmontes Awaiting requested review from fmontes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Custom Hook for Page View Content Analytics Integration
4 participants
@oidacra @fmontes @nicobytes @hmoreras