fix(rest-api) improve error handling for 415 unsupported media type #30828 #30910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinogiardino
requested review from
jgambarios,
nollymar and
fabrizzio-dotCMS
nollymar
reviewed
Dec 10, 2024
dotCMS/src/main/java/com/dotcms/rest/exception/mapper/NotSupportedExceptionMapper.java
Show resolved
Hide resolved
nollymar
approved these changes
Dec 10, 2024
fabrizzio-dotCMS
approved these changes
Dec 10, 2024
fabrizzio-dotCMS
deleted the
issue-30828-rest-api-improve-error-handling-for-415-unsupported-media-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
NotSupportedExceptionMapperto handlejavax.ws.rs.NotSupportedExceptionand return JSON responses for415 Unsupported Media Typeerrors.Content-Typeheaders.Checklist
Additional Info
This PR addresses the issue where REST endpoints annotated with
@Consumes(multipart/form-data)would return HTML responses instead of JSON when theContent-Typeheader is incorrect. The new implementation ensures consistency and better user experience by providing meaningful JSON error messages across the application.Screenshots
This PR fixes: #30828