-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FTM): New UVE Toolbar - Implement Workflows Action button #30908
Merged
rjvelazco
merged 19 commits into
main
from
issue-30737-ftm-new-uve-toolbar-implement-workflows-action-button
Dec 16, 2024
Merged
feat(FTM): New UVE Toolbar - Implement Workflows Action button #30908
rjvelazco
merged 19 commits into
main
from
issue-30737-ftm-new-uve-toolbar-implement-workflows-action-button
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkflows-action-button
…kflowactionservice
…rkflows-action-button
rjvelazco
requested review from
zJaaal,
KevinDavilaDotCMS,
fmontes,
oidacra,
nicobytes,
hmoreras and
valentinogiardino
and removed request for
zJaaal and
KevinDavilaDotCMS
December 13, 2024 15:12
oidacra
reviewed
Dec 13, 2024
...portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.spec.ts
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Dec 13, 2024
...it-ema-editor/components/dot-uve-workflow-actions/dot-uve-workflow-actions.component.spec.ts
Outdated
Show resolved
Hide resolved
…rkflows-action-button
fmontes
approved these changes
Dec 16, 2024
core-web/libs/ui/src/lib/components/dot-workflow-actions/dot-workflow-actions.component.html
Show resolved
Hide resolved
zJaaal
approved these changes
Dec 16, 2024
rjvelazco
deleted the
issue-30737-ftm-new-uve-toolbar-implement-workflows-action-button
branch
December 16, 2024 21:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the
DotEmaShellComponent
and related components to integrate theDotWorkflowsActionsService
and enhance workflow actions functionality. The most important changes include adding the new service to multiple components, updating component templates, and refactoring theDotUveWorkflowActionsComponent
.Integration of
DotWorkflowsActionsService
:DotWorkflowsActionsService
to the imports and providers indot-ema-shell.component.ts
anddot-ema-shell.component.spec.ts
to enable workflow actions. [1] [2] [3] [4]Component Template Updates:
dot-uve-workflow-actions
component indot-uve-toolbar.component.html
to improve the user interface for workflow actions.dot-uve-workflow-actions.component.html
to disable actions when editing is not allowed.Refactoring
DotUveWorkflowActionsComponent
:dot-edit-ema-workflow-actions
todot-uve-workflow-actions
and refactored the component to useUVEStore
for managing state and actions. [1] [2] [3] [4] [5] [6]Test Updates:
dot-ema-info-display.component.spec.ts
anddot-uve-toolbar.component.spec.ts
to accommodate the new service and component changes. [1] [2] [3] [4] [5] [6] [7]Codebase Simplification:
DotUveToolbarComponent
by removing unused properties and methods, and integrating the new workflow actions component. [1] [2] [3] [4]Videos
issue-30737-ftm-new-uve-toolbar-implement-workflows-action-button.mov
This PR fixes: #30737