Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FTM): New UVE Toolbar - Implement Workflows Action button #30908

Merged

Conversation

rjvelazco
Copy link
Contributor

@rjvelazco rjvelazco commented Dec 10, 2024

This pull request introduces several changes to the DotEmaShellComponent and related components to integrate the DotWorkflowsActionsService and enhance workflow actions functionality. The most important changes include adding the new service to multiple components, updating component templates, and refactoring the DotUveWorkflowActionsComponent.

Integration of DotWorkflowsActionsService:

  • Added DotWorkflowsActionsService to the imports and providers in dot-ema-shell.component.ts and dot-ema-shell.component.spec.ts to enable workflow actions. [1] [2] [3] [4]

Component Template Updates:

  • Replaced the workflows button with the dot-uve-workflow-actions component in dot-uve-toolbar.component.html to improve the user interface for workflow actions.
  • Updated the dot-uve-workflow-actions.component.html to disable actions when editing is not allowed.

Refactoring DotUveWorkflowActionsComponent:

  • Renamed dot-edit-ema-workflow-actions to dot-uve-workflow-actions and refactored the component to use UVEStore for managing state and actions. [1] [2] [3] [4] [5] [6]

Test Updates:

  • Added mock providers and updated test cases in dot-ema-info-display.component.spec.ts and dot-uve-toolbar.component.spec.ts to accommodate the new service and component changes. [1] [2] [3] [4] [5] [6] [7]

Codebase Simplification:

  • Simplified DotUveToolbarComponent by removing unused properties and methods, and integrating the new workflow actions component. [1] [2] [3] [4]

Videos

issue-30737-ftm-new-uve-toolbar-implement-workflows-action-button.mov

This PR fixes: #30737

@rjvelazco rjvelazco linked an issue Dec 11, 2024 that may be closed by this pull request
@rjvelazco rjvelazco marked this pull request as ready for review December 13, 2024 15:11
@rjvelazco rjvelazco requested a review from oidacra December 16, 2024 15:01
@rjvelazco rjvelazco added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 7503306 Dec 16, 2024
36 checks passed
@rjvelazco rjvelazco deleted the issue-30737-ftm-new-uve-toolbar-implement-workflows-action-button branch December 16, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FTM: New UVE Toolbar - Implement Workflows Action button
4 participants