chore(uve): Add Device Selector functionality #30903
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
requested review from
rjvelazco,
fmontes and
KevinDavilaDotCMS
and removed request for
rjvelazco
| @@ -140,6 +140,19 @@ export function withEditor() { | |||
| const origin = params.clientHost || window.location.origin; | |||
| const iframeURL = new URL(pageAPIQueryParams, origin); | |||
|
|
|||
| const unit = device?.inode !== 'default' ? BASE_IFRAME_MEASURE_UNIT : '%'; | |||
|
|
|||
| const wrapper = | |||
There was a problem hiding this comment.
This can be a function? is a little difficult to read
| }, | ||
| actionIcon: 'pi pi-times' | ||
| }; | ||
| } else if (!getIsDefaultVariant(pageAPIResponse?.viewAs.variantId)) { |
There was a problem hiding this comment.
the else is not necessary i think
|
|
||
| // So we dont open the editor in a device | ||
| if (!this.#store.$isPreviewMode() && (deviceInode || orientation)) { | ||
| this.#store.patchViewParams({ device: null, orientation: null }); |
There was a problem hiding this comment.
Doesn't this generate a loop any time?
Maybe it should be in an untracked()
There was a problem hiding this comment.
No it doesn't but I haven't tested this code properly, so Im sure this can be better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP