chore(uve): Add Persona Selector to New Toolbar #30856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
requested review from
KevinDavilaDotCMS,
fmontes and
rjvelazco
and removed request for
KevinDavilaDotCMS,
fmontes and
rjvelazco
zJaaal
requested review from
oidacra,
nicobytes,
valentinogiardino and
hmoreras
|
It's code ready but I found an issue and I want to investigate it before moving foward. Update: Is fixed |
…735' of https://github.com/dotCMS/core into 30736-ftm-new-uve-toolbar-implement-persona-selector-30735
...portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.spec.ts
Outdated
Show resolved
Hide resolved
...portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.spec.ts
Outdated
Show resolved
Hide resolved
KevinDavilaDotCMS
approved these changes
Dec 5, 2024
rjvelazco
approved these changes
Dec 6, 2024
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/toolbar/withUVEToolbar.ts
Show resolved
Hide resolved
zJaaal
deleted the
30736-ftm-new-uve-toolbar-implement-persona-selector-30735
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements to the
dot-uve-toolbarcomponent, focusing on improving persona management and adding new services. The most significant changes include the integration of a persona selector component, updates to handle persona selection and despersonalization, and modifications to the state management for persona properties.This PR also fixes a found issue, where every time we deleted content from a page for a specific persona, there were cases where the content was being save for the default persona, messing up with the page for the default persona.
Before the fix
Screen.Recording.2024-12-05.at.2.mp4
After the fix
Screen.Recording.2024-12-05.at.2.23.50.PM-1.mov
Enhancements to persona management:
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.html: Replaced the static persona selector span with thedot-edit-ema-persona-selectorcomponent, adding event bindings for persona selection and despersonalization.core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.ts: Added imports forDotPersonalizeServiceandDotPersona, included theEditEmaPersonaSelectorComponentin the component declarations, and introduced methodsonPersonaSelectedandonDespersonalizeto handle persona-related actions. [1] [2] [3]State management updates:
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/models.ts: Removed thepersonaSelectorproperty fromUVEToolbarPropsand created a newPersonaSelectorPropsinterface. [1] [2]core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/toolbar/withUVEToolbar.ts: Updated the state management to include a computed$personaSelectorproperty that returns the current persona selector properties. [1] [2]core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/toolbar/withUVEToolbar.spec.ts: Added a test case to verify the persona selector properties in the store. [1] [2] [3]This PR fixes: #30736