feat(FTM): New UVE Toolbar - Implement "API" button #30830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjvelazco
changed the title
rjvelazco
requested review from
zJaaal,
fmontes,
KevinDavilaDotCMS,
oidacra,
nicobytes and
hmoreras
and removed request for
zJaaal and
fmontes
valentinogiardino
approved these changes
Dec 3, 2024
zJaaal
approved these changes
Dec 3, 2024
rjvelazco
deleted the
issue-30733-ftm-new-uve-toolbar-implement-api-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
DotUveToolbarComponentand related files to enhance the functionality and testing of the API URL link. The most important changes include updating the toolbar component to use an anchor tag for the API URL link, adding a computed property for the API URL, and enhancing the tests to verify the correct behavior of the API URL link.Changes to
DotUveToolbarComponent:<a>) tag instead of a button for the API URL link, and added attributes such astitle,target, andhrefto improve accessibility and functionality. ([core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.htmlL19-R26](https://github.com/dotCMS/core/pull/30830/files#diff-9937556e73b051b878ba22ad1ce971a70019a617d7979b3e0bcc814801ad350bL19-R26))Enhancements to testing:
$apiURLand updated theDotUveToolbarComponenttests to include this constant and verify the presence and correctness of the API URL link. ([[1]](https://github.com/dotCMS/core/pull/30830/files#diff-3eaa147616a5d1ff374a5fa27b0f38f0159a9039ef7e8d672dec43631f48a9e1R38-R39),[[2]](https://github.com/dotCMS/core/pull/30830/files#diff-3eaa147616a5d1ff374a5fa27b0f38f0159a9039ef7e8d672dec43631f48a9e1R123),[[3]](https://github.com/dotCMS/core/pull/30830/files#diff-3eaa147616a5d1ff374a5fa27b0f38f0159a9039ef7e8d672dec43631f48a9e1L177-L180),[[4]](https://github.com/dotCMS/core/pull/30830/files#diff-3eaa147616a5d1ff374a5fa27b0f38f0159a9039ef7e8d672dec43631f48a9e1R195-R205))Computed property for API URL:
$apiURLin theDotUveToolbarComponentto dynamically generate the API URL based on the page parameters. ([[1]](https://github.com/dotCMS/core/pull/30830/files#diff-217a9e619d6590c4f652e85353b9637ba5e464ddeb0424be35aef39bb8dceb30R34),[[2]](https://github.com/dotCMS/core/pull/30830/files#diff-e6d3fb6319626fa85a4fc6894b57935843713366be593de6dd1dc5ed68bf6afcR119-R127))New test for
withUVEToolbar:withUVEToolbar.spec.tsto verify the computed property$apiURLand ensure it returns the correct API URL based on given page parameters. ([core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/toolbar/withUVEToolbar.spec.tsR1-R83](https://github.com/dotCMS/core/pull/30830/files#diff-7a5de702ac1dc81304f4c31816f5c0363aa56141f8afa583a87856e7a0d8482dR1-R83))Videos
Traditional
Screen.Recording.2024-12-03.at.11.14.25.AM.mov
Headless
Screen.Recording.2024-12-03.at.11.16.02.AM.mov
This PR fixes: #30733