chore(uve): FTM - Implement "CopyURL" button on UVE Toolbar #30819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinDavilaDotCMS
requested review from
zJaaal,
fmontes,
oidacra,
nicobytes,
hmoreras,
rjvelazco and
valentinogiardino
zJaaal
approved these changes
Dec 2, 2024
...portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.spec.ts
Show resolved
Hide resolved
rjvelazco
approved these changes
Dec 2, 2024
nollymar
deleted the
30732-ftm-new-uve-toolbar-implement-copy-url-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
DotUveToolbarComponentto enhance its functionality and improve the testing setup. The most important changes include adding a copy-to-clipboard feature, updating the test suite to cover new functionality, and importing necessary modules and services.Enhancements to
DotUveToolbarComponent:core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.html,core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.ts) [1] [2]Updates to test suite:
DebugElement,By, andMessageServicefor testing purposes. (core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.spec.ts)MessageServiceto the test providers and injected it into the test suite. (core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.spec.ts) [1] [2] [3]MessageServicewhen the copy-to-clipboard event is triggered. (core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.spec.ts)This PR fixes: #30732