Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(edit-content): Basic Relationship field Layout #30794

Conversation

nicobytes
Copy link
Contributor

@nicobytes nicobytes commented Nov 27, 2024

Parent Issue

#30515

Proposed Changes

This pull request introduces a new RELATIONSHIP field type in the dotCMS content editing module. The most important changes include the addition of the DotEditContentRelationshipFieldComponent, updates to the FIELD_TYPES enum, and the creation of supporting components and stores for managing relationship fields.

Introduction of RELATIONSHIP Field Type:

New Components for Relationship Fields:

Supporting Stores and Utilities:

Template and Style Updates:

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)
2024-11-28.14-18-18.mp4

This PR fixes: #30515

@nicobytes nicobytes changed the title chore(edit-content): UI with mock data #30515 chore(edit-content): UI with mock data Nov 27, 2024
@nicobytes nicobytes changed the title chore(edit-content): UI with mock data chore(edit-content): Basic Relationship field Layout Nov 28, 2024
@nicobytes nicobytes marked this pull request as ready for review November 28, 2024 18:23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 18 changed files in this pull request and generated no suggestions.

Files not reviewed (13)
  • core-web/libs/dotcms-scss/shared/_colors.scss: Language not supported
  • core-web/libs/edit-content/src/lib/components/dot-edit-content-field/dot-edit-content-field.component.html: Language not supported
  • core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/components/pagination/pagination.component.html: Language not supported
  • core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/components/search/search.compoment.html: Language not supported
  • core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/dot-select-existing-content.component.html: Language not supported
  • core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/dot-select-existing-content.component.scss: Language not supported
  • core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.html: Language not supported
  • core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.scss: Language not supported
  • dotCMS/src/main/webapp/WEB-INF/messages/Language.properties: Language not supported
  • core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.ts: Evaluated as low risk
  • core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/store/relationship-field.store.ts: Evaluated as low risk
  • core-web/libs/edit-content/src/lib/models/dot-edit-content-field.enum.ts: Evaluated as low risk
  • core-web/libs/edit-content/src/lib/components/dot-edit-content-form/utils.ts: Evaluated as low risk
Comments skipped due to low confidence (1)

core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/components/search/search.compoment.ts:1

  • The filename and selector have a typo. It should be 'search.component.ts' and 'dot-search', respectively.
import { Component, inject, output } from '@angular/core';
@nicobytes nicobytes requested a review from fmontes November 29, 2024 15:39
@nicobytes nicobytes requested a review from oidacra November 29, 2024 15:54
@nicobytes nicobytes enabled auto-merge November 29, 2024 17:47
@nicobytes nicobytes added this pull request to the merge queue Nov 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2024
@nicobytes nicobytes added this pull request to the merge queue Nov 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2024
@nicobytes nicobytes added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@nicobytes nicobytes enabled auto-merge December 3, 2024 03:53
@nicobytes nicobytes added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 7a64a00 Dec 3, 2024
36 checks passed
@nicobytes nicobytes deleted the 30515-create-basic-relationship-field-structure-for-edit-contentlet branch December 3, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Basic Relationship Field Structure for Edit Contentlet
3 participants