New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(JobQueue) Implement import content job rest endpoint #30669 #30698

Merged

nollymar merged 38 commits into main from issue-30669-create-import-job-rest-endpoint

Nov 25, 2024

Contributor

valentinogiardino commented Nov 19, 2024 •

edited by github-actions bot

Loading

Proposed Changes

Added a new REST resource (ContentImportResource) to handle content import job operations, including creating and enqueuing content import jobs.
Added a helper class (ContentImportHelper) to manage content import operations, including methods for creating and managing jobs.
Created a bean class (ContentImportParams) to encapsulate multipart form parameters for content import operations.
Introduced a form object (ContentImportForm) to represent JSON parameters for content import operations.

Checklist

Tests
Translations
Security Implications Contemplated (add notes if applicable)

Additional Info

These changes aim to provide a REST endpoint for managing content import jobs, enabling operations like job creation and queueing.

This PR fixes: #30669

valentinogiardino added 4 commits

November 19, 2024 11:07


          #30669 add ContentImportForm

f14fa05


          #30669 add contentImport params

3f04f62


          #30669 add contentimport helper

3631fd4


          #30669 add contentImport resource

a33f47c

valentinogiardino linked an issue

that may be closed by this pull request

[Content Import Job Management] Implement the Create Import Job REST endpoint #30669

Closed

6 tasks


          Merge branch 'main' into issue-30669-create-import-job-rest-endpoint

e3d982b

github-actions bot mentioned this pull request

[Content Import Job Management] Implement the Create Import Job REST endpoint #30669

Closed

6 tasks

valentinogiardino and others added 4 commits

November 19, 2024 11:46


          #30669 add params validation

40311d9


          #30669 fix extract jobQueueManagerAPI init and destroy

c6e620f


          Update JobQueueHelper.java

ea4fa2e


          Merge branch 'main' into issue-30669-create-import-job-rest-endpoint

aeb5c8e

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/JobQueueManagerHelper.java Show resolved Hide resolved

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/JobQueueManagerHelper.java Outdated Show resolved Hide resolved

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/JobQueueManagerHelper.java Show resolved Hide resolved

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/JobQueueManagerHelper.java Outdated Show resolved Hide resolved

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/JobQueueManagerHelper.java Show resolved Hide resolved

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/JobQueueManagerHelper.java Show resolved Hide resolved

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/JobQueueManagerHelper.java Outdated Show resolved Hide resolved

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/JobQueueManagerHelper.java Outdated Show resolved Hide resolved

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/contentImport/ContentImportForm.java Outdated Show resolved Hide resolved

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/contentImport/ContentImportHelper.java Outdated Show resolved Hide resolved

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/contentImport/ContentImportHelper.java Outdated Show resolved Hide resolved

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/contentImport/ContentImportHelper.java Outdated Show resolved Hide resolved

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/contentImport/ContentImportHelper.java Outdated Show resolved Hide resolved

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/contentImport/ContentImportResource.java Outdated Show resolved Hide resolved

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/contentImport/ContentImportResource.java Outdated Show resolved Hide resolved

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/contentImport/ContentImportResource.java Outdated Show resolved Hide resolved

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/contentImport/ContentImportResource.java Outdated Show resolved Hide resolved

jdotcms reviewed

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/contentImport/ContentImportResource.java Outdated Show resolved Hide resolved


          #30669 add ContentUploadResourceIntegrationTest

f6814a2

valentinogiardino and others added 4 commits

November 22, 2024 00:07


          #30669 use constants

5df1df3


          #30669 rename package

fb10066


          #30669 add postman tests

c6d72ba


          Merge branch 'main' into issue-30669-create-import-job-rest-endpoint

33b256e

valentinogiardino marked this pull request as ready for review

November 22, 2024 12:59

valentinogiardino changed the title ~~Issue 30669 create import job rest endpoint~~ feat(JobQueue) Implement import content job rest endpoint #30669

valentinogiardino requested review from jgambarios, nollymar, fabrizzio-dotCMS and jdotcms

November 22, 2024 13:11

jgambarios approved these changes

View reviewed changes


          #30669 set to final

78525cd

nollymar reviewed

View reviewed changes

...c/test/java/com/dotcms/rest/api/v1/content/_import/ContentImportResourceIntegrationTest.java Show resolved Hide resolved

nollymar reviewed

View reviewed changes

...c/test/java/com/dotcms/rest/api/v1/content/_import/ContentImportResourceIntegrationTest.java Outdated Show resolved Hide resolved

nollymar reviewed

View reviewed changes

...c/test/java/com/dotcms/rest/api/v1/content/_import/ContentImportResourceIntegrationTest.java Outdated Show resolved Hide resolved

nollymar reviewed

View reviewed changes

...c/test/java/com/dotcms/rest/api/v1/content/_import/ContentImportResourceIntegrationTest.java Outdated Show resolved Hide resolved

valentinogiardino and others added 8 commits

November 22, 2024 16:54


          #30669 fix postman tests

b15005b


          #30669 fix unnecessary defining methods as static

6cd497d


          #30669 fix add new integration test class to suit

adc213a


          #30669 fix it

3ccb323


          typo

9563b64


          #30669 fix it

9fc6270


          #30669 add cleanUp

b01e94d


          Merge branch 'main' into issue-30669-create-import-job-rest-endpoint

1a4e1c1

dotcms-sonarqube bot commented Nov 23, 2024

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

nollymar approved these changes

View reviewed changes

nollymar added this pull request to the merge queue

Merged via the queue into main with commit f4195a7

37 checks passed

nollymar deleted the issue-30669-create-import-job-rest-endpoint branch

November 25, 2024 18:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet