chore(uve): Add FF for Preview Mode #30623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
requested review from
fmontes,
oidacra,
hmoreras,
rjvelazco,
valentinogiardino and
KevinDavilaDotCMS
oidacra
approved these changes
Nov 12, 2024
…e' of https://github.com/dotCMS/core into 30459-ftm-create-feature-flag-to-enable-new-preview-mode
Screen.Recording.2024-11-12.at.5.10.51.PM.mov |
rjvelazco
requested changes
Nov 12, 2024
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/flags/withFlags.ts
Show resolved
Hide resolved
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/flags/withFlags.spec.ts
Outdated
Show resolved
Hide resolved
rjvelazco
approved these changes
Nov 12, 2024
valentinogiardino
approved these changes
Nov 12, 2024
|
zJaaal
deleted the
30459-ftm-create-feature-flag-to-enable-new-preview-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature flag for UVE preview mode and integrates it into the existing system. The changes include updates to feature flag definitions, component additions, and modifications to the store to handle the new flag.
Feature Flag Updates:
FEATURE_FLAG_UVE_PREVIEW_MODEtoFeaturedFlagsinshared-models.ts.ConfigurationResource.javato includeFEATURE_FLAG_UVE_PREVIEW_MODEin the list of feature flags.Component Additions:
DotUveToolbarComponentwith its HTML, SCSS, and TypeScript files. [1] [2] [3]Store Modifications:
withFlagsfeature to handle the fetching and state management of feature flags indot-uve.store.ts. [1] [2]flags/models.tsandflags/withFlags.ts. [1] [2]Component Integration:
DotUveToolbarComponentintoedit-ema-editor.component.htmland updated SCSS accordingly. [1] [2]edit-ema-editor.component.tsto include the new toolbar component. [1] [2] [3]This PR fixes: #30459