feat(edit-content) show files according to host/folder #30612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of github.com:dotCMS/core into 30215-select-existing-file-show-hostfolder-on-the-left
… of github.com:dotCMS/core into 30215-select-existing-file-show-hostfolder-on-the-left
…ing-to-hostfolder-with-e2e
nicobytes
changed the title
hmoreras
reviewed
Nov 8, 2024
...-field/components/dot-select-existing-file/components/dot-sidebar/dot-sidebar.component.scss
Show resolved
Hide resolved
oidacra
reviewed
Nov 8, 2024
oidacra
approved these changes
Nov 8, 2024
hmoreras
approved these changes
Nov 8, 2024
|
nicobytes
deleted the
30216-select-existing-file-show-files-according-to-hostfolder-with-e2e
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent Issue
#30216
Proposed Changes
This pull request includes several changes across multiple files to enhance the functionality and organization of the
dot-siteanddot-edit-content-file-fieldcomponents. The key changes involve adding a new method to fetch content by folder, refactoring imports for better modularity, and updating UI components for improved user interaction.Enhancements to
dot-site.service.ts:ContentByFolderParamsto define parameters for fetching content by folder.getContentByFolderinDotSiteServiceto fetch content based on the provided parameters.Refactoring imports in
dot-edit-content-file-fieldcomponents:dot-file-field-preview.component.ts,dot-file-field-ui-message.component.ts,dot-form-file-editor.component.ts,form-file-editor.store.ts,dot-form-import-url.component.spec.ts, andform-import-url.store.ts. [1] [2] [3] [4] [5] [6]UI Improvements in
dot-select-existing-filecomponents:dot-dataview.component.htmlto include better data binding and UI elements such as loading indicators, search functionality, and improved table structure. [1] [2]dot-dataview.component.scssto include styles for new UI elements like truncation and thumbnail display.dot-dataview.component.tsto use new Angular features like signals and models for state management.dot-sidebar.component.htmlanddot-sidebar.component.tsto handle node selection and state management more effectively. [1] [2] [3] [4] [5]dot-select-existing-file.component.htmlanddot-select-existing-file.component.tsto handle folder loading and content selection more efficiently. [1] [2] [3] [4] [5]These changes collectively enhance the functionality, modularity, and user experience of the
dot-siteanddot-edit-content-file-fieldcomponents.Checklist
Additional Info
2024-11-08.16-57-00.mp4
This PR fixes: #30216