chore(edit-content): implement endpoint to fetch sites #30562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of github.com:dotCMS/core into 30215-select-existing-file-show-hostfolder-on-the-left
zJaaal
reviewed
Nov 6, 2024
...le-field/components/dot-select-existing-file/components/dot-sidebar/dot-sidebar.component.ts
Outdated
Show resolved
Hide resolved
zJaaal
reviewed
Nov 6, 2024
...le-field/components/dot-select-existing-file/components/dot-sidebar/dot-sidebar.component.ts
Show resolved
Hide resolved
… of github.com:dotCMS/core into 30215-select-existing-file-show-hostfolder-on-the-left
zJaaal
approved these changes
Nov 6, 2024
oidacra
approved these changes
Nov 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
hmoreras
approved these changes
Nov 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
nicobytes
deleted the
30215-select-existing-file-show-hostfolder-on-the-left
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent Issue
#30215
Proposed Changes
This pull request includes multiple changes to the
dot-siteservice and thedot-select-existing-filecomponent, primarily focusing on adding pagination support and improving the file selection UI and its state management.DotSiteService Enhancements:
DEFAULT_PAGEconstant and included apageparameter in thegetSitesmethod to support pagination. (core-web/libs/data-access/src/lib/dot-site/dot-site.service.ts) [1] [2]pageparameter in the URLs. (core-web/libs/data-access/src/lib/dot-site/dot-site.service.spec.ts) [1] [2]DotSelectExistingFile Component Enhancements:
dot-sidebarcomponent to handle loading states and display skeleton loaders while data is being fetched. (core-web/libs/edit-content/src/lib/fields/dot-edit-content-file-field/components/dot-select-existing-file/components/dot-sidebar/dot-sidebar.component.html,core-web/libs/edit-content/src/lib/fields/dot-edit-content-file-field/components/dot-select-existing-file/components/dot-sidebar/dot-sidebar.component.ts) [1] [2]dot-sidebarcomponent to dynamically load child nodes. (core-web/libs/edit-content/src/lib/fields/dot-edit-content-file-field/components/dot-select-existing-file/dot-select-existing-file.component.html)SelectExisingFileStoreto cover folder loading and child node expansion logic. (core-web/libs/edit-content/src/lib/fields/dot-edit-content-file-field/components/dot-select-existing-file/store/select-existing-file.store.test.ts)SelectExisingFileStoreto manage the state of folder nodes, including loading states and expanded nodes. (core-web/libs/edit-content/src/lib/fields/dot-edit-content-file-field/components/dot-select-existing-file/store/select-existing-file.store.ts) [1] [2] [3] [4] [5]Miscellaneous:
dot-select-existing-filecomponent to improve layout and styling. (core-web/libs/edit-content/src/lib/fields/dot-edit-content-file-field/components/dot-select-existing-file/dot-select-existing-file.component.scss)file-field.store.spec.tsto useTestBedfor dependency injection and added missing imports. (core-web/libs/edit-content/src/lib/fields/dot-edit-content-file-field/store/file-field.store.spec.ts) [1] [2]Checklist
Screenshots
2024-11-05.18-20-03.mp4
This PR fixes: #30215