Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#29742 apitoken doc IQA fixes & more #30265

Merged
merged 2 commits into from
Oct 7, 2024
Merged

#29742 apitoken doc IQA fixes & more #30265

merged 2 commits into from
Oct 7, 2024

Conversation

jdcmsd
Copy link
Contributor

@jdcmsd jdcmsd commented Oct 4, 2024

This addresses everything raised in this IQA doc, and then further issues I found while working on that initial batch. I won't go point by point on this in the bullets below, because it's quite a lot and I've completely lost track of them all. But I'll list the biggest ones I can remember.

Proposed Changes

  • All concerns in document addressed
  • Both forms edited
    • ApiTokenForm got a couple of @Hidden annotations for unnecessary props
    • RemoteApiTokenForm had a bunch of variables renamed so error messages make more sense if a key property is omitted.
  • Both user-based revocation endpoints have been @Hidden, as neither of them appears to work.
    • (Also found another unrelated bug in the API token UI; separate issue forthcoming. )
  • Various text fixes
  • Various schema fixes
  • Various response example fixes
  • Several endpoint descriptions corrected
  • Various request body description and/or example fixes
  • Tag adjustment

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

This PR fixes: #29742

@jdcmsd jdcmsd linked an issue Oct 4, 2024 that may be closed by this pull request
@jdcmsd jdcmsd linked an issue Oct 7, 2024 that may be closed by this pull request
@nollymar nollymar added this pull request to the merge queue Oct 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 7, 2024
@nollymar nollymar added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 7d5223d Oct 7, 2024
34 checks passed
@nollymar nollymar deleted the 29742-IQA-fixes-etc branch October 7, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to delete API tokens via UI Swagger Documentation for /v1/api-token Endpoints
3 participants