Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment): Edit Page V2 Automate the deploy of the SDK librar (#28259) #29795

Merged

Conversation

dcolina
Copy link
Contributor

@dcolina dcolina commented Aug 30, 2024

Proposed Changes

  • This PR fixes an issue with malformed JSON payloads in Slack notifications when the message contains newline characters (\n). This issue affected all Slack notifications after the recent refactor to encapsulate the Slack notification functionality, including notifications related to new Docker image creation.

Changes:

  • Updated Action (notify-slack): Utilized the toJSON function to correctly format the payload input, ensuring special characters are properly escaped for JSON.
  • Improved Slack Notification Handling: Prevents errors caused by improper formatting of multi-line messages.

These changes ensure reliable and correctly formatted Slack notifications in GitHub Actions.

Additional Info

Related to #28259 (Edit Page V2 Automate the deploy of the SDK librar).

Screenshots

Original Updated
** original screenshot ** ** updated screenshot **

This PR fixes: #28259

@dcolina dcolina requested a review from a team as a code owner August 30, 2024 10:13
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@nollymar nollymar added this pull request to the merge queue Aug 30, 2024
Merged via the queue into master with commit a2b20d5 Aug 30, 2024
31 checks passed
@nollymar nollymar deleted the issue-28259-fix-slack-notification-sdk-deployment-automation branch August 30, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit Page V2: Automate the deploy of the SDK libraries
3 participants