-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): React Block Editor Render Component #29653
Merged
KevinDavilaDotCMS
merged 22 commits into
master
from
29369-sdk-create-block-editor-render-component-for-reactjs
Sep 3, 2024
Merged
feat(sdk): React Block Editor Render Component #29653
KevinDavilaDotCMS
merged 22 commits into
master
from
29369-sdk-create-block-editor-render-component-for-reactjs
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
…esting, some types and doc
zJaaal
requested changes
Aug 26, 2024
core-web/libs/sdk/react/src/lib/components/BlockEditorRenderer/blocks/Video.tsx
Outdated
Show resolved
Hide resolved
KevinDavilaDotCMS
requested review from
fmontes,
nicobytes,
hmoreras,
rjvelazco and
valentinogiardino
August 26, 2024 17:51
Check SQ Issues, there are 23. |
zJaaal
changed the title
Working on BlockEditorRenderer component
feat(sdk): React Block Editor Render Component
Aug 26, 2024
rjvelazco
requested changes
Aug 26, 2024
core-web/libs/sdk/react/src/lib/components/BlockEditorRenderer/blocks/Contentlet.tsx
Outdated
Show resolved
Hide resolved
fmontes
requested changes
Aug 27, 2024
core-web/libs/sdk/react/src/lib/components/BlockEditorRenderer/BlockEditorRenderer.tsx
Outdated
Show resolved
Hide resolved
core-web/libs/sdk/react/src/lib/components/BlockEditorRenderer/item/BlockEditorItem.tsx
Outdated
Show resolved
Hide resolved
core-web/libs/sdk/react/src/lib/components/BlockEditorRenderer/item/BlockEditorItem.tsx
Outdated
Show resolved
Hide resolved
fmontes
approved these changes
Aug 28, 2024
rjvelazco
approved these changes
Aug 28, 2024
zJaaal
requested changes
Aug 28, 2024
core-web/libs/sdk/react/src/lib/components/BlockEditorRenderer/item/BlockEditorItem.tsx
Outdated
Show resolved
Hide resolved
core-web/libs/sdk/react/src/lib/components/BlockEditorRenderer/BlockEditorRenderer.tsx
Outdated
Show resolved
Hide resolved
core-web/libs/sdk/react/src/lib/components/BlockEditorRenderer/blocks/Code.tsx
Outdated
Show resolved
Hide resolved
core-web/libs/sdk/react/src/lib/components/BlockEditorRenderer/blocks/Contentlet.tsx
Outdated
Show resolved
Hide resolved
zJaaal
approved these changes
Aug 30, 2024
core-web/libs/sdk/react/src/lib/components/BlockEditorRenderer/blocks/Texts.tsx
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
KevinDavilaDotCMS
deleted the
29369-sdk-create-block-editor-render-component-for-reactjs
branch
September 3, 2024 16:32
dsolistorres
pushed a commit
that referenced
this pull request
Sep 18, 2024
### Proposed Changes * Added BlockEditorRenderer component in React SDK * Render all supported Blocks and Marks * Allow to render Blocks with customRenderer components * Allow apply custom classes and styles Heading: https://github.com/user-attachments/assets/e8c9591e-6a11-4c00-a6ed-459491950807 Marks: https://github.com/user-attachments/assets/d7be80c2-37fb-4e63-a7a4-a213372cf7b9 Lists: https://github.com/user-attachments/assets/b2c0bc56-a637-49cd-b3c9-7ad8a67ea6af Code: https://github.com/user-attachments/assets/749eee63-d883-44e6-bb8b-95a513cc1b6b Images: https://github.com/user-attachments/assets/4bac2f6f-7c08-4e97-a97c-5d57823c209b Video: https://github.com/user-attachments/assets/a9ae666e-811b-4114-beb9-bc4e37c40f02 Table: https://github.com/user-attachments/assets/419c5b32-6f3e-489c-ad89-7e1fd90c9384 Contentlet: https://github.com/user-attachments/assets/73fbede7-f4ff-4fb3-af4e-75a3aab3528f --------- Co-authored-by: Kevin Davila <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Heading:
Heading.mov
Marks:
Marks.mov
Lists:
Lists.mov
Code:
Code.mov
Images:
Images.mov
Video:
Video.mov
Table:
Table.mov
Contentlet:
Contentlet.mov
This PR fixes: #29369