Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix error in show parent #29638

Merged
merged 3 commits into from
Aug 19, 2024
Merged

chore: fix error in show parent #29638

merged 3 commits into from
Aug 19, 2024

Conversation

nicobytes
Copy link
Contributor

@nicobytes nicobytes commented Aug 19, 2024

Parent Issue

#29489

Proposed Changes

  • Fix bug in map to show path
  • Add query param to get ParentList attr

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Screenshots

Original Updated
Screenshot 2024-08-08 at 10 12 38 AM Screenshot 2024-08-08 at 10 13 00 AM

This PR fixes: #29489

This PR fixes: #29489

@nicobytes
Copy link
Contributor Author

2024-08-19.10-46-23.mp4

@fmontes
Copy link
Member

fmontes commented Aug 19, 2024

Out of topic but

CleanShot 2024-08-19 at 08 55 07@2x

@nicobytes
Copy link
Contributor Author

Out of topic but

CleanShot 2024-08-19 at 08 55 07@2x

Fixed!

Screenshot 2024-08-19 at 1 33 12 PM

@nicobytes nicobytes requested a review from fmontes August 19, 2024 17:43
@nicobytes nicobytes enabled auto-merge August 19, 2024 21:16
@nicobytes nicobytes added this pull request to the merge queue Aug 19, 2024
Merged via the queue into master with commit 325cd51 Aug 19, 2024
18 checks passed
@nicobytes nicobytes deleted the 29489-fix-error branch August 19, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the path in selected items
4 participants