-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(design system): Fix large font-sizes inconsistencies #28724 #29611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
valentinogiardino
changed the title
Merged chore(design system): Fix large font-sizes inconsistencies #28724
chore(design system): Fix large font-sizes inconsistencies #28724
Aug 16, 2024
KevinDavilaDotCMS
approved these changes
Aug 16, 2024
valentinogiardino
requested review from
oidacra,
zJaaal,
rjvelazco and
KevinDavilaDotCMS
August 16, 2024 13:38
KevinDavilaDotCMS
approved these changes
Aug 16, 2024
hmoreras
approved these changes
Aug 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Aug 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 16, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
lmd
withmd
lg
withlmd
xl
withlg
xxl
withxl
xxxl
withxxl
dot-apps
.cw-rule
font-size for rules portletAdditional Info
This PR fixes #28724. The previous pull request failed QA due to some inconsistencies.
This PR includes missing replacements, specifically for font sizes
$font-size-lmd
,lg
,xl
,xxl
, andxxxl
. The extensive changes to files are due to these replacements. Care was taken to avoid modifying font sizes that were corrected in the previous PR.The replacement process followed this order to avoid collisions:
lmd
tomd
,lg
tolmd
,xl
tolg
,xxl
toxl
, andxxxl
toxxl
. Additionally, missing font size properties were added to portlets where they were previously omitted, including indot-apps
, templates, and containers portlets.Screenshots
This PR fixes: #28724