Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(design system): Fix large font-sizes inconsistencies #28724 #29611

Merged
merged 10 commits into from
Aug 16, 2024

Conversation

valentinogiardino
Copy link
Contributor

@valentinogiardino valentinogiardino commented Aug 16, 2024

Proposed Changes

  • Replaced lmd with md
  • Replaced lg with lmd
  • Replaced xl with lg
  • Replaced xxl with xl
  • Replaced xxxl with xxl
  • Corrected font-size in dot-apps
  • Adjusted font-size for "show archive" label in templates and containers portlets
  • Updated .cw-rule font-size for rules portlet

Additional Info

This PR fixes #28724. The previous pull request failed QA due to some inconsistencies.

This PR includes missing replacements, specifically for font sizes $font-size-lmd, lg, xl, xxl, and xxxl. The extensive changes to files are due to these replacements. Care was taken to avoid modifying font sizes that were corrected in the previous PR.

The replacement process followed this order to avoid collisions: lmd to md, lg to lmd, xl to lg, xxl to xl, and xxxl to xxl. Additionally, missing font size properties were added to portlets where they were previously omitted, including in dot-apps, templates, and containers portlets.

Screenshots

Original (Header) Updated
image image
Original (show archive) Updated
image image
Original (apps cards) Updated
image image
Original (apps detail) Updated
image image
Original (apps form) Updated
image image
Original (rules "evaluate") Updated
image image
Original (overlaypanel titles) Updated
image image

This PR fixes: #28724

@valentinogiardino valentinogiardino self-assigned this Aug 16, 2024
@valentinogiardino valentinogiardino changed the title Merged chore(design system): Fix large font-sizes inconsistencies #28724 chore(design system): Fix large font-sizes inconsistencies #28724 Aug 16, 2024
@valentinogiardino valentinogiardino added this pull request to the merge queue Aug 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 16, 2024
@valentinogiardino valentinogiardino added this pull request to the merge queue Aug 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 16, 2024
Copy link

@valentinogiardino valentinogiardino added this pull request to the merge queue Aug 16, 2024
Merged via the queue into master with commit 8f7cae3 Aug 16, 2024
18 checks passed
@valentinogiardino valentinogiardino deleted the 28724-fix-large-font-sizes branch August 16, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Update Base Font Size to 14px
3 participants