#29281: Several dotAI enhancements #29588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victoralfaro-dotcms
force-pushed
the
29587-dotAI-logs-exception-handling-enhancements
branch
3 times, most recently
from
7fc1b01 to
7aa5eb8
Compare
…d 'type' instead of just a list os strings. Throwing exceptions when AppConfig.isEnabled() is false to break the tests when any of AI API url or AI API key are missing. Clean the default values for model names. Added better logging at key places when interacting with OpenAI provider. Tests were added/updated.
victoralfaro-dotcms
force-pushed
the
29587-dotAI-logs-exception-handling-enhancements
branch
from
7aa5eb8 to
c3f04da
Compare
jcastro-dotcms
approved these changes
Aug 14, 2024
victoralfaro-dotcms
force-pushed
the
29587-dotAI-logs-exception-handling-enhancements
branch
from
c5d5b01 to
4c54f36
Compare
|
nollymar
approved these changes
Aug 15, 2024
nollymar
approved these changes
Aug 15, 2024
victoralfaro-dotcms
deleted the
29587-dotAI-logs-exception-handling-enhancements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning available models as object that includes 'name' and 'type' instead of just a list os strings. Throwing exceptions when AppConfig.isEnabled() is false to break the tests when any of AI API url or AI API key are missing. Clean the default values for model names. Added better logging at key places when interacting with OpenAI provider. Tests were added/updated.
This PR fixes: #29587