Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor-content): implement breadcrumb navigation for categories #29394

Merged
merged 31 commits into from
Aug 2, 2024
Merged

feat(editor-content): implement breadcrumb navigation for categories #29394

merged 31 commits into from
Aug 2, 2024

Conversation

nicobytes
Copy link
Contributor

@nicobytes nicobytes commented Jul 30, 2024 •
edited by github-actions bot
Loading

Parent Issue

#29184

Proposed Changes

  • Implement dot-collapse-breadcrumb in SideMenu for CategoryField
  • Create getMenuItemsFromKeyParentPath util to get Breadcrumb navigation
  • Use output()
  • Use viewChild Signal
  • Use model Signal

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

References

Screenshot 2024-07-10 at 12 16 04 PM Screenshot 2024-07-10 at 12 16 12 PM Screenshot 2024-07-10 at 12 16 19 PM

Screenshots

2024-07-31.16-03-13.mp4

This PR fixes: #29184

@nicobytes nicobytes linked an issue Jul 30, 2024 that may be closed by this pull request
Implement Breadcrumb Navigation for Categories #29184
Closed
@nicobytes nicobytes changed the title 29184 implement breadcrumb navigation for categories feat(editor-content): implement breadcrumb navigation for categories Jul 31, 2024
@nicobytes nicobytes marked this pull request as ready for review July 31, 2024 18:58
@nicobytes nicobytes requested a review from fmontes August 1, 2024 00:54
@nicobytes nicobytes enabled auto-merge August 1, 2024 15:35
@nicobytes nicobytes requested a review from oidacra August 2, 2024 14:49
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@nicobytes nicobytes added this pull request to the merge queue Aug 2, 2024
Merged via the queue into master with commit 30d2813 Aug 2, 2024
30 checks passed
@nicobytes nicobytes deleted the 29184-implement-breadcrumb-navigation-for-categories branch August 2, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmoreras hmoreras hmoreras approved these changes

@oidacra oidacra oidacra approved these changes

@rjvelazco rjvelazco Awaiting requested review from rjvelazco

@zJaaal zJaaal Awaiting requested review from zJaaal

@fmontes fmontes Awaiting requested review from fmontes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Breadcrumb Navigation for Categories
3 participants
@nicobytes @oidacra @hmoreras