Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(edit-content): add remove functionality to category chips #29216

Merged
merged 19 commits into from
Jul 15, 2024
Merged

feat(edit-content): add remove functionality to category chips #29216

merged 19 commits into from
Jul 15, 2024

Conversation

nicobytes
Copy link
Contributor

@nicobytes nicobytes commented Jul 12, 2024 •
edited by github-actions bot
Loading

Proposed Changes

  • Sync selected categories with categoryFieldControl with an effect
  • Implement onRemove event in Chips component

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Additional Info

2024-07-12.17-37-19.mp4

This PR fixes: #29181

@nicobytes nicobytes requested a review from oidacra July 12, 2024 22:01
Base automatically changed from issue-28879-search-categoryfield-2 to master July 12, 2024 22:50
@nicobytes nicobytes marked this pull request as ready for review July 13, 2024 12:45
@nicobytes nicobytes linked an issue Jul 13, 2024 that may be closed by this pull request
Delete Selected Category from Input Tags #29181
Closed
@nicobytes nicobytes enabled auto-merge July 15, 2024 14:20
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@nicobytes nicobytes added this pull request to the merge queue Jul 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 15, 2024
@nicobytes nicobytes added this pull request to the merge queue Jul 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 15, 2024
@nicobytes nicobytes added this pull request to the merge queue Jul 15, 2024
Merged via the queue into master with commit 61105d1 Jul 15, 2024
18 checks passed
@nicobytes nicobytes deleted the 29181-delete-selected-category branch July 15, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjvelazco rjvelazco rjvelazco approved these changes

@zJaaal zJaaal zJaaal approved these changes

@hmoreras hmoreras hmoreras approved these changes

@oidacra oidacra oidacra approved these changes

@fmontes fmontes fmontes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete Selected Category from Input Tags
6 participants
@nicobytes @fmontes @oidacra @hmoreras @zJaaal @rjvelazco