#28896 Create Factory method to find categories in all levels #29021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-all-levels-Category
…r-all-levels-Category
jcastro-dotcms
requested changes
Jun 26, 2024
dotCMS/src/main/java/com/dotmarketing/portlets/categories/business/CategoryFactoryImpl.java
Outdated
Show resolved
Hide resolved
jdotcms
reviewed
Jun 26, 2024
dotCMS/src/main/java/com/dotmarketing/portlets/categories/business/CategoryFactoryImpl.java
Outdated
Show resolved
Hide resolved
…Category' of https://github.com/dotCMS/core into issue-28896-Create-Factory-Method-to-filter-all-levels-Category
jdotcms
approved these changes
Jun 26, 2024
jcastro-dotcms
approved these changes
Jun 27, 2024
dsilvam
reviewed
Jul 1, 2024
dotCMS/src/main/java/com/dotmarketing/portlets/categories/business/CategoryFactory.java
Outdated
Show resolved
Hide resolved
jcastro-dotcms
approved these changes
Jul 1, 2024
dsilvam
reviewed
Jul 1, 2024
...gration/src/test/java/com/dotmarketing/portlets/categories/business/CategoryFactoryTest.java
Outdated
Show resolved
Hide resolved
dsilvam
reviewed
Jul 1, 2024
...gration/src/test/java/com/dotmarketing/portlets/categories/business/CategoryFactoryTest.java
Outdated
Show resolved
Hide resolved
dsilvam
approved these changes
Jul 1, 2024
|
freddyDOTCMS
deleted the
issue-28896-Create-Factory-Method-to-filter-all-levels-Category
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR for #28896
Later I am going to use this Factory to create a API Method
Proposed Changes
https://github.com/dotCMS/core/pull/29021/files#diff-bf828c747c99cefe73af7cec527db7f7e64bd4a66ba54a55eb1170f6a2996333R844
https://github.com/dotCMS/core/pull/29021/files#diff-bf828c747c99cefe73af7cec527db7f7e64bd4a66ba54a55eb1170f6a2996333R863
We already have a method to find the ALL the categories and it update the cache after execute the query, so I created a Util method to share the code.
https://github.com/dotCMS/core/pull/29021/files#diff-bf828c747c99cefe73af7cec527db7f7e64bd4a66ba54a55eb1170f6a2996333R168
Checklist
Additional Info
** any additional useful context or info **
Screenshots
This PR fixes: #28896