Filter system host when is isRequired #28931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equired-then-we-do-not-allowshow-system_host
nicobytes
requested review from
rjvelazco,
fmontes,
oidacra and
KevinDavilaDotCMS
zJaaal
requested changes
Jun 18, 2024
...bs/edit-content/src/lib/fields/dot-edit-content-host-folder-field/store/methods/loadSites.ts
Outdated
Show resolved
Hide resolved
zJaaal
approved these changes
Jun 18, 2024
zJaaal
approved these changes
Jun 18, 2024
…equired-then-we-do-not-allowshow-system_host
oidacra
reviewed
Jun 19, 2024
...it-content/src/lib/fields/dot-edit-content-host-folder-field/store/methods/loadSites.spec.ts
Show resolved
Hide resolved
oidacra
approved these changes
Jun 19, 2024
|
Are we sure this is the right approach? Because why required will exclude the system host? What about load without a value and if is marked as required user will have to add a value and that value could be system host. If we don't want the user to select system host we can do something else? Blacklist maybe? I don't know all the details behind this reasoning, but this is a component we might be using in a lot of places. |
|
@fmontes RE: don't show system host if required: |
fmontes
requested changes
Jun 19, 2024
...bs/edit-content/src/lib/fields/dot-edit-content-host-folder-field/store/methods/loadSites.ts
Show resolved
Hide resolved
fmontes
approved these changes
Jun 19, 2024
…equired-then-we-do-not-allowshow-system_host
|
nicobytes
deleted the
28924-if-a-hostfolder-field-is-marked-as-required-then-we-do-not-allowshow-system_host
branch
oidacra
pushed a commit
that referenced
this pull request
Jun 26, 2024
If a host/folder field is marked as required, then we do not allow/show SYSTEM_HOST ### Proposed Changes * Add isRequired attr to enable filter ### Checklist - [x] Tests - [x] Translations - [x] Security Implications Contemplated (add notes if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a host/folder field is marked as required, then we do not allow/show SYSTEM_HOST
Proposed Changes
Checklist
This PR fixes: #28924