Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLI): Watch Mode Refs:#28593 #28710

Merged
merged 17 commits into from
Jun 11, 2024
Merged

feat(CLI): Watch Mode Refs:#28593 #28710

merged 17 commits into from
Jun 11, 2024

Conversation

fabrizzio-dotCMS
Copy link
Contributor

@fabrizzio-dotCMS fabrizzio-dotCMS commented May 31, 2024

Proposed Changes

  • We're introducing Watch options in the Push Mixin so they become available to every push subcommand
  • We're adding a bit of logic in the DotExecutionStrategy to be able to handle starting up in watch mode and continue to repeat execution of the command of choice
  • I'm making DotPush a descendant of DotCommand to help me select all Push commands and still gain access to the mixins.
  • Because of the above change I needed to tell the global Push command from the others, so I introduced a new getter with such info.
  • Symmetry-wise wise I made DotPull also a descendant of DotCommand. But just for symmetry. All Pull sub commands got modified when I removed the no longer-needed DotCommand interface. But there are no other changes in logic.
  • A DirectoryWatchService was introduced. this class uses a poll interval to observe and filter events.
  • The events captured by the service are filtered so, let's say a folder move that in reality creates between 4 and 5 events (FOLDER_MODIFY, FOLDER_DELETE, FOLDER_MODIFY, FOLDER_CREATE), These events are filtered so that we only get the most recent one. This ensures we do not flood the server side with many unneeded changes.
  • Changes in documentation were made
  • Tests were introduced for the DirectoryWatchService, The Global Push running with the watch mode flag on, and finally another one to cover the changes introduced in the DotExecutionStrategy

@fabrizzio-dotCMS fabrizzio-dotCMS changed the title #28593 testing multithreaded global Push approach feat(CLI): Watch Mode Refs:#28593 Jun 7, 2024
@fabrizzio-dotCMS fabrizzio-dotCMS marked this pull request as ready for review June 10, 2024 15:28
@fabrizzio-dotCMS fabrizzio-dotCMS linked an issue Jun 10, 2024 that may be closed by this pull request
@nollymar nollymar added this pull request to the merge queue Jun 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 10, 2024
@nollymar nollymar added this pull request to the merge queue Jun 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 11, 2024
@fabrizzio-dotCMS fabrizzio-dotCMS added this pull request to the merge queue Jun 11, 2024
Merged via the queue into master with commit ee92044 Jun 11, 2024
16 checks passed
@fabrizzio-dotCMS fabrizzio-dotCMS deleted the issue-28593-watch branch June 11, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File System Watcher
3 participants