-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CLI): Watch Mode Refs:#28593 #28710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to issue-28593-watch
fabrizzio-dotCMS
changed the title
#28593 testing multithreaded global Push approach
feat(CLI): Watch Mode Refs:#28593
Jun 7, 2024
…to issue-28593-watch
Quality Gate passedIssues Measures |
Closed
jgambarios
approved these changes
Jun 10, 2024
nollymar
approved these changes
Jun 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jun 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
DotExecutionStrategy
to be able to handle starting up in watch mode and continue to repeat execution of the command of choiceDotPush
a descendant ofDotCommand
to help me select all Push commands and still gain access to the mixins.DotPull
also a descendant ofDotCommand
. But just for symmetry. All Pull sub commands got modified when I removed the no longer-needed DotCommand interface. But there are no other changes in logic.DirectoryWatchService
, The Global Push running with the watch mode flag on, and finally another one to cover the changes introduced in theDotExecutionStrategy