-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Treeselect in Site/Folder at Edit Content #28700
Merged
nicobytes
merged 43 commits into
master
from
28645-use-treeselect-in-sitefolder-at-edit-content
Jun 10, 2024
Merged
Use Treeselect in Site/Folder at Edit Content #28700
nicobytes
merged 43 commits into
master
from
28645-use-treeselect-in-sitefolder-at-edit-content
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicobytes
changed the title
Use of new syntax and upgrade to prettier support for new syntax
Use Treeselect in Site/Folder at Edit Content
May 30, 2024
…ite /folder field #28645
nicobytes
requested review from
oidacra,
KevinDavilaDotCMS,
rjvelazco and
fmontes
June 6, 2024 21:22
...edit-content/src/lib/components/dot-edit-content-field/dot-edit-content-field.component.html
Show resolved
Hide resolved
oidacra
reviewed
Jun 7, 2024
core-web/libs/edit-content/src/lib/services/dot-edit-content.service.ts
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Jun 7, 2024
fmontes
approved these changes
Jun 7, 2024
...elds/dot-edit-content-host-folder-field/dot-edit-content-host-folder-field.component.spec.ts
Show resolved
Hide resolved
...ib/fields/dot-edit-content-host-folder-field/dot-edit-content-host-folder-field.component.ts
Show resolved
Hide resolved
core-web/libs/edit-content/src/lib/services/dot-edit-content.service.ts
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Jun 7, 2024
core-web/libs/edit-content/src/lib/models/dot-edit-content-host-folder-field.interface.ts
Show resolved
Hide resolved
oidacra
reviewed
Jun 7, 2024
...ib/fields/dot-edit-content-host-folder-field/dot-edit-content-host-folder-field.component.ts
Show resolved
Hide resolved
oidacra
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
rjvelazco
approved these changes
Jun 10, 2024
.../fields/dot-edit-content-host-folder-field/dot-edit-content-host-folder-field.component.html
Outdated
Show resolved
Hide resolved
...ib/fields/dot-edit-content-host-folder-field/dot-edit-content-host-folder-field.component.ts
Outdated
Show resolved
Hide resolved
.../portlet/src/lib/edit-ema-editor/components/edit-ema-toolbar/edit-ema-toolbar.component.html
Outdated
Show resolved
Hide resolved
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.html
Outdated
Show resolved
Hide resolved
…github.com:dotCMS/core into 28645-use-treeselect-in-sitefolder-at-edit-content
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#28645
Checklist
User Story
As a Content Architect in dotCMS, I want to add a Site/Folder field to the Edit Content Form so I can easily create and edit content.
Current behavior
The actual field uses the old design system and the idea is to implement the new TreeSelectComponent.
Screenshots
Acceptance Criteria
External Links
Video Support
2024-06-05.17-38-53.mp4