feat(edit-content) add category field #28658 #28690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oidacra
force-pushed
the
issue-28658-add-empty-category-field
branch
from
087a009 to
f314942
Compare
oidacra
changed the title
oidacra
force-pushed
the
issue-28658-add-empty-category-field
branch
from
f314942 to
12b7744
Compare
oidacra
requested review from
rjvelazco,
zJaaal,
KevinDavilaDotCMS,
fmontes,
nicobytes and
hmoreras
...edit-content/src/lib/components/dot-edit-content-field/dot-edit-content-field.component.html
Show resolved
Hide resolved
rjvelazco
previously requested changes
Jun 3, 2024
...dot-edit-content-category-field-dialog/dot-edit-content-category-field-dialog.component.html
Outdated
Show resolved
Hide resolved
...dot-edit-content-category-field-dialog/dot-edit-content-category-field-dialog.component.html
Show resolved
Hide resolved
...dot-edit-content-category-field-dialog/dot-edit-content-category-field-dialog.component.html
Show resolved
Hide resolved
.../src/lib/fields/dot-edit-content-category-field/dot-edit-content-category-field.component.ts
Outdated
Show resolved
Hide resolved
nicobytes
approved these changes
Jun 3, 2024
...dot-edit-content-category-field-dialog/dot-edit-content-category-field-dialog.component.scss
Outdated
Show resolved
Hide resolved
fmontes
previously requested changes
Jun 3, 2024
...edit-content/src/lib/components/dot-edit-content-field/dot-edit-content-field.component.scss
Outdated
Show resolved
Hide resolved
...dot-edit-content-category-field-dialog/dot-edit-content-category-field-dialog.component.scss
Outdated
Show resolved
Hide resolved
Comment on lines
+35
to
+31
| ::ng-deep .category-field__dialog .p-dialog-content { | ||
| padding: 0; | ||
| } |
There was a problem hiding this comment.
This in the one that needs the nested with the :host.
There was a problem hiding this comment.
For any reason, the host of the component and the host of the dynamic dialog it not the same, one is ng-tns-c3177718326-21, and the component _nghost-ng-c2079007228 and no reach the expected div. Anyway, I need change from dialog to sidebar soon.
There was a problem hiding this comment.
This is dangerous because it can affect other dialogs in the page, no?
There was a problem hiding this comment.
It will be deleted. In the draft of the change to use sidebar instead, I rid of those lines.
...rc/lib/fields/dot-edit-content-category-field/dot-edit-content-category-field.component.html
Outdated
Show resolved
Hide resolved
...rc/lib/fields/dot-edit-content-category-field/dot-edit-content-category-field.component.scss
Outdated
Show resolved
Hide resolved
...rc/lib/fields/dot-edit-content-category-field/dot-edit-content-category-field.component.scss
Outdated
Show resolved
Hide resolved
...lib/fields/dot-edit-content-category-field/dot-edit-content-category-field.component.spec.ts
Show resolved
Hide resolved
oidacra
force-pushed
the
issue-28658-add-empty-category-field
branch
from
fa8b9e4 to
10da22a
Compare
.../src/lib/fields/dot-edit-content-category-field/dot-edit-content-category-field.component.ts
Outdated
Show resolved
Hide resolved
hmoreras
approved these changes
Jun 5, 2024
|
zJaaal
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Additional Info
Screen.Recording.2024-05-30.at.9.04.00.PM.mov
Screenshots
Input
Dialog
