-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(backend): Test Java 21 and identify next steps after illegal (#28622) #28623
Closed
spbolton
wants to merge
51
commits into
master
from
issue-28622-test-java-21-and-identify-next-steps-after-illegal
Closed
chore(backend): Test Java 21 and identify next steps after illegal (#28622) #28623
spbolton
wants to merge
51
commits into
master
from
issue-28622-test-java-21-and-identify-next-steps-after-illegal
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spbolton
force-pushed
the
issue-28622-test-java-21-and-identify-next-steps-after-illegal
branch
4 times, most recently
from
May 22, 2024 02:40
a06d8b7
to
318ddff
Compare
spbolton
force-pushed
the
issue-28622-test-java-21-and-identify-next-steps-after-illegal
branch
from
June 3, 2024 10:09
83b67ae
to
f4c1c76
Compare
spbolton
force-pushed
the
issue-28622-test-java-21-and-identify-next-steps-after-illegal
branch
from
June 3, 2024 10:21
f4c1c76
to
a890c91
Compare
) Bumps [next](https://github.com/vercel/next.js) from 14.1.0 to 14.1.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vercel/next.js/commit/5f59ee5f197a09275da7a9fa876986f22f4b7711"><code>5f59ee5</code></a> v14.1.1</li> <li><a href="https://github.com/vercel/next.js/commit/f48b90b162c1a27a1ecaa8ae0a452e0a6605c35f"><code>f48b90b</code></a> even more</li> <li><a href="https://github.com/vercel/next.js/commit/7f789f4a6f6a4f89495c770bed74d5e5d0e01d44"><code>7f789f4</code></a> more timeout</li> <li><a href="https://github.com/vercel/next.js/commit/ab71c4cf782e13d564f48fe15732b9c42a3f6f36"><code>ab71c4c</code></a> update timeout</li> <li><a href="https://github.com/vercel/next.js/commit/75f60d92c43187aa5786f88f0fe4e2bfc7d44c7b"><code>75f60d9</code></a> update trigger release workflow</li> <li><a href="https://github.com/vercel/next.js/commit/74b3f0f4f3dcc15f35c9b9956755ca7b7b6a6db5"><code>74b3f0f</code></a> Server Action tests (<a href="https://redirect.github.com/vercel/next.js/issues/62655">#62655</a>)</li> <li><a href="https://github.com/vercel/next.js/commit/a6946b69ccb268015887ea6d6ef39f262e5636b1"><code>a6946b6</code></a> Backport metadata fixes (<a href="https://redirect.github.com/vercel/next.js/issues/62663">#62663</a>)</li> <li><a href="https://github.com/vercel/next.js/commit/4002f4b33c5a42166e5ad5f9ff4f879195aeb852"><code>4002f4b</code></a> Fix draft mode invariant (<a href="https://redirect.github.com/vercel/next.js/issues/62121">#62121</a>)</li> <li><a href="https://github.com/vercel/next.js/commit/7dbf6f8298daea8e8c5198e9a4e7e758da665a6d"><code>7dbf6f8</code></a> fix: babel usage with next/image (<a href="https://redirect.github.com/vercel/next.js/issues/61835">#61835</a>)</li> <li><a href="https://github.com/vercel/next.js/commit/3efc842a0a30ffd3a991e45736ac615f336d3103"><code>3efc842</code></a> Fix next/server apit push alias for ESM pkg (<a href="https://redirect.github.com/vercel/next.js/issues/61721">#61721</a>)</li> <li>Additional commits viewable in <a href="https://github.com/vercel/next.js/compare/v14.1.0...v14.1.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=next&package-manager=npm_and_yarn&previous-version=14.1.0&new-version=14.1.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/dotCMS/core/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Arcadio Quintero <[email protected]>
Dimensions should display as `{Width} x {Height}` instead of `{Height} x {Width}` in the dropdown; this just swaps them. Solves #28517. Redo of #28520, but this time I'm not working off a fork, so that should simplify things! Signed-off-by: Jamie Mauro <[email protected]>
- Allow users to `drag and drop` files when creating a new Asset on Firefox. ### Video https://github.com/dotCMS/core/assets/72418962/d6b673fd-7185-440c-bc6e-957c7442179d
- Reload the page after any change on the same route in edit mode. ### Video https://github.com/dotCMS/core/assets/72418962/b6789ad1-ce06-40cd-9bc7-c7eedb880b80
### Proposed Changes * Upon adding a query param we get language variables count info * Also adding an endpoint to get languages and countries provided by JVM * Respective postman and IT
first PR for: #28588 I am going to use this Method later to clean the MultiTreeCache ### Proposed Changes * Create Factory method to get Experiment by Host https://github.com/dotCMS/core/pull/28628/files#diff-21c1ce5a843f846838109d8270b67fb2a386b5cd7c9b45234d30c0d9ad34117bR53
trying to upgrade graphql to 17.5
### Proposed Changes * Update the dependencies of SDK to the examples to the latest version in NPM ### Checklist - [ ] Tests - [ ] Translations - [ ] Security Implications Contemplated (add notes if applicable) ### Additional Info ** any additional useful context or info ** ### Screenshots
This is a last PR for #22033 First one: #28530 Second one: #28564 third one: #28586 On this PR we are starting the PruneTimeMachineJob, this need to be starter when the TimeMachineJob is started. ### Proposed Changes * Start the Prune Time machineJob after start the TimeMachineJob https://github.com/dotCMS/core/pull/28586/files#diff-d6eb70242764e7e3dbcffc3d0bac20c485b0879b72118925714bb30e37d1ac9aR507 * We need to remove the files under the bundle folder too https://github.com/dotCMS/core/pull/28586/files#diff-19b28e2982b6db869240fb8fc96a2bf2c156e3607f41656fd16d7845c45ba604R231 When TimeMachine run it created the Bundle folder under the bundles folder and later copy it to the timemachine folder, we need to remove both ### Checklist - [x] Tests - [ ] ### Additional Info Later I am going to sent a last PR with the Stop logic --------- Co-authored-by: Daniel Silva <[email protected]>
…28650) ### Proposed Changes * edit embedded contentlet only JSP ### Checklist - [ ] Tests - [ ] Translations - [ ] Security Implications Contemplated (add notes if applicable) ### Additional Info ** any additional useful context or info ** ### Screenshots https://github.com/dotCMS/core/assets/1909643/752fb4f4-3cdd-401d-bb9d-c71b8909c611
### Proposed Changes * Check if the page is a variant before setting the mode of the editor ### Screenshots https://github.com/dotCMS/core/assets/63567962/c79e31cb-e3ab-4b93-a25e-201f6b811489
… (#28642) ### Proposed Changes * Fix filtering of language not country codes and add missing entries * Tests should work but will only really know when we do not see the issue re-occur. ### Checklist - [ ] Tests - [ ] Translations - [ ] Security Implications Contemplated (add notes if applicable) ### Additional Info Related to #28640 (Flakey test Language randomization causes conflic). ### Screenshots Original | Updated :-------------------------:|:-------------------------: ** original screenshot ** | ** updated screenshot **
…8633) Now, when updating a content type we don't depend solely on the ID, but we use now the variable as a secondary key if needed.
### Proposed Changes * Using Pagination to get Contentlets on the PP process https://github.com/dotCMS/core/pull/28660/files#diff-5973b5c1a487e762b9efec075463674e9309b98787f28ad43a5191094b84fb34R195 * Refactoring the tryToAddAllAndProcessDependencies method to support Iterable https://github.com/dotCMS/core/pull/28660/files#diff-5973b5c1a487e762b9efec075463674e9309b98787f28ad43a5191094b84fb34R915
second PR for: #28588 first one: #28628 Refactor MultiTreeCache to make it cluster-aware. Previously, we used the Page ID as the key in the MultiTreeCache, storing a map where each key represented a different variant name and each value was a MultiTree. When we needed to remove a variant, we followed these steps: Removed the item from the map representing the variant. Put the updated map back into the cache. However, the put method was not cluster-aware. You can see the relevant code here: https://github.com/dotCMS/core/blob/eb200d27482a557634e0f732ed5f055c0df28450/dotCMS/src/main/java/com/dotmarketing/cache/MultiTreeCache.java#L91-L103 ### Proposed Changes * Create the listActive Experiment API Method to get all the Active Experiment by Host https://github.com/dotCMS/core/pull/28630/files#diff-8bf1865184fd59c5c64882df72bd0c71a403a544777830acf250bbf54ea84d90R271 * Use Page's id + variant Name as Cache key https://github.com/dotCMS/core/pull/28630/files#diff-ad644a666145836b324394468b653fe572daf6de9d1e434752ec44eca7fdf9a4R53 so we don't need the Map anymore * When we need to remove all the variants for a Page, we use the new listActive API Method https://github.com/dotCMS/core/pull/28630/files#diff-ad644a666145836b324394468b653fe572daf6de9d1e434752ec44eca7fdf9a4R99 ### Checklist - [x] Tests
Include logging of backups deleted
### Proposed Changes *Better clean up code for lang variables test. Prevents breakage in tests
### Proposed Changes - Add more tests - Migrate to JWT auth ### Checklist - [ ] Tests - [ ] Security Implications ### Additional Info ** any additional useful context or info ** --------- Signed-off-by: bryanboza <[email protected]>
… in the table. (#28669) ### Proposed Changes * add the menu options to the locale table and the confirmation messages. * Push Publish * Set As Default * Delete ### Screenshots https://github.com/dotCMS/core/assets/31667212/646d62f0-b6d3-4f8d-b9e4-173e955160b8
## Proposed Changes * Add `Content` Class to handle Content API Methods and expose it as a method of the Dotcms Client * Add `GetCollection` Class to handle the building of a query for collections and expose it as a method of `Content` Class ## Usage example for standalone `getCollection` This an example of a query with all possible methods it supports (could not be a real use case and it should be used from the `client.content`). ```typescript const requestOptions: Omit<RequestInit, 'body' | 'method'> = { cache: 'no-cache' // To simulate a valid request }; const serverUrl = 'http://localhost:8080'; const contentType = 'forceSensitive'; const client = new GetCollection(requestOptions, serverUrl, contentType); const response = await client .language(13) // Language Id .render(true) // To retrieve the content with the render .sortBy([ // Sort by multiple fields { field: 'name', order: 'asc' }, { field: 'midichlorians', order: 'desc' } ]) .depth(2) // Depth of the content for relationships .limit(20) // Limit of content per page .page(3) // Page to fetch .query( ( qb // Lucene query to append to the main query for more complex queries ) => qb .field('kyberCrystal') .equals('red') .and() .equals('blue') .field('master') .equals('Yoda') .or() .equals('Obi-Wan') ) .draft(true) // To retrieve the draft content .variant('legends-forceSensitive') // Variant of the content .rawQuery('+modDate:2024-05-28 +conhost:MyCoolSite') // Raw query to append to the main query .fetch(); // Fetch the content ```
… fields (#28683) Now, when updating the content type fields, we don't depend solely on the field ID, but we use now the field variable as a secondary key if needed. --------- Co-authored-by: Daniel Enrique Colina Rodríguez <[email protected]>
### Proposed Changes * Clicking the “Copy URL” button to copy the URL to the clipboard ### Video #### VTL Page https://github.com/dotCMS/core/assets/72418962/7959ad28-e6a8-4a03-bc4d-ddcb7aca7300 #### Headless https://github.com/dotCMS/core/assets/72418962/c6000f68-3ccf-4e89-be7b-437fc34d69a8
…nore when invalid (#28707) This is to prevent a HTML injection.
### Proposed Changes * Adding a minified version of the Vanity URL object to the JSON response when processing a Forward status code, for troubleshooting purposes. * Adding the `X-DOT-VanityUrl` Response Header just like we do when accessing Vanity URLs in the front-end.
Include Upgrade Task to add the dotAI portlet by default. Integration test included. Update empty starter with a new one that includes the dotAI portlet.
### Proposed Changes * Moved all SDK logic to standalone lib in NX workspace * This PR introduces a new method to create a links from the example apps to sdk libs, using compilerOptions on tsconfig file. To test it, build the angular sdk lib and run the angular example in core/core-web: `npx nx run sdk-angular:build` then `ng serve` in examples/angular This way can be used in other sdk/examples apps --------- Co-authored-by: KevinDavilaDotCMS <[email protected]>
### Proposed Changes * Ensure that all rows of cards have a consistent height. ### Video https://github.com/dotCMS/core/assets/72418962/f73b7e1f-09e0-4d22-9fba-39c7a130e5bf
### Proposed Changes - Let users edit pages without problems even if you are in the free version. ### Videos #### Community Edition https://github.com/dotCMS/core/assets/72418962/c8d4a703-64b4-4d5b-a29d-9005588e10e9 #### License https://github.com/dotCMS/core/assets/72418962/6e9e56a2-3c9f-41a7-a2ec-4b33b0a01c08
spbolton
force-pushed
the
issue-28622-test-java-21-and-identify-next-steps-after-illegal
branch
from
June 3, 2024 10:23
a890c91
to
be3b397
Compare
Quality Gate passedIssues Measures |
7 tasks
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Additional Info
Related to #28622 (Test Java 21 and identify next steps after illegal).
Screenshots