Edit Contentlet: Allow File Preview #26613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjvelazco
requested review from
fmontes and
zJaaal
and removed request for
fmontes
rjvelazco
requested review from
oidacra,
manuelrojas,
hmoreras and
KevinDavilaDotCMS
|
SonarQube Quality Gate
|
|
SonarQube Quality Gate
|
hmoreras
approved these changes
Nov 7, 2023
manuelrojas
approved these changes
Nov 7, 2023
fmontes
approved these changes
Nov 7, 2023
fmontes
deleted the
issue-26105-edit-contentlet-allow-file-preview-fix-edit-code
branch
|
Pipeline is failing, but since this code is not related to Java is ok to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at e287a83
Improved the binary field component and its storybook and test files. Removed unused dependencies and operators from the
binary-field.component.stories.tsfile. Added logic and tests for previewing and editing unknown file types in thedot-binary-field-previewcomponent.Related Issue
Fixes #26105
Explanation of Changes
🤖 Generated by Copilot at e287a83
unknownvalue toEDITABLE_FILEenum and updated logic for settingcontenttypeandisEditableproperties to handle unknown files in the preview component (link,link,link)fileUnknownand test suite for unknown files in the preview component spec file (link,link)Video
Screen.Recording.2023-11-07.at.11.22.43.AM.mov