Fix #26440: Edit Content Routing on Content search were broken #26593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
requested review from
fmontes,
oidacra,
manuelrojas,
hmoreras,
rjvelazco and
KevinDavilaDotCMS
jdotcms
approved these changes
Nov 1, 2023
rjvelazco
approved these changes
Nov 1, 2023
dotCMS/src/main/webapp/html/portlet/ext/contentlet/view_contentlets_js_inc.jsp
Outdated
Show resolved
Hide resolved
dotCMS/src/main/webapp/html/portlet/ext/contentlet/view_contentlets_js_inc.jsp
Outdated
Show resolved
Hide resolved
oidacra
approved these changes
Nov 6, 2023
…r-new-content-in-content-search
…r-new-content-in-content-search
fmontes
approved these changes
Nov 6, 2023
…r-new-content-in-content-search
|
SonarQube Quality Gate
|
hmoreras
approved these changes
Nov 7, 2023
fmontes
deleted the
26440-edit-content-navigation-is-broken-for-new-content-in-content-search
branch
|
Pipeline is failing, but since this code is not related to Java is ok to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at f45f08c
Summary
♻️🔧🔥
This pull request refactors and simplifies the JSP files that handle the contentlet management. It eliminates code duplication by including the JavaScript functions from
view_contentlets_js_inc.jspinview_contentlets.jsp, and streamlines theaddNewContentletfunction to use only the content type inode as a parameter. It also removes an unused variable fromview_contentlets.jsp.Walkthrough
view_contentlets_js_inc.jspfile content toview_contentlets.jspfile to avoid unnecessary includes (link)addNewContentletfunction signature to accept only content type inode and get content type variable name from hidden inputs (link)velocityVarNamefromview_contentlets.jspfile and its assignments (link, link, link)addNewContentletfunction calls inview_contentlets.jspfile (link, link)Screenshots
Screen.Recording.2023-11-01.at.3.09.52.PM.mov