Edit Contentlet: Allow User Write Code - fix SonarQube regex warning #26475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
approved these changes
Oct 19, 2023
…te-code-fix-regex
rjvelazco
requested review from
fmontes,
oidacra,
manuelrojas,
hmoreras and
KevinDavilaDotCMS
|
SonarQube Quality Gate
|
oidacra
approved these changes
Oct 20, 2023
hmoreras
approved these changes
Oct 20, 2023
manuelrojas
approved these changes
Oct 20, 2023
fmontes
deleted the
issue-26045-edit-contentlet-allow-user-write-code-fix-regex
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at 6bf570e
Improve binary field editor component by extracting file name validation regex. This change enhances the performance and readability of the
dot-binary-field-editorcomponent by moving the regular expression for validating the file name to a private fieldregexindot-binary-field-editor.component.ts.Related Issue
Fixes #26045
Explanation of Changes
🤖 Generated by Copilot at 6bf570e
regexto improve performance and readability (link)