Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Contentlet: Allow User Write Code - Add Monaco Editor #26433

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Edit Contentlet: Allow User Write Code - Add Monaco Editor #26433

merged 2 commits into from
Oct 13, 2023

Conversation

rjvelazco
Copy link
Contributor

@rjvelazco rjvelazco commented Oct 12, 2023 •
edited
Loading

Description

🤖 Generated by Copilot at 58b07a0

Implement Monaco Editor in Dojo v1

Related Issue

Fixes #26045

@rjvelazco rjvelazco requested review from fmontes and hmoreras October 12, 2023 21:27
@rjvelazco rjvelazco marked this pull request as ready for review October 12, 2023 21:28
@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fmontes fmontes merged commit 398d818 into master Oct 13, 2023
27 of 30 checks passed
@fmontes fmontes deleted the issue-26045-edit-contentlet-allow-user-write-code-add-monaco-editor-in-dojo branch October 13, 2023 22:31
@rjvelazco rjvelazco mentioned this pull request Nov 2, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zJaaal zJaaal zJaaal approved these changes

@manuelrojas manuelrojas manuelrojas approved these changes

@oidacra oidacra oidacra approved these changes

@fmontes fmontes fmontes approved these changes

@hmoreras hmoreras Awaiting requested review from hmoreras

@KevinDavilaDotCMS KevinDavilaDotCMS Awaiting requested review from KevinDavilaDotCMS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit Contentlet: Allow User Write Code
5 participants
@rjvelazco @fmontes @oidacra @manuelrojas @zJaaal