Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Contentlet: Allow User Write Code #26426

Merged
merged 13 commits into from
Oct 18, 2023
Merged

Edit Contentlet: Allow User Write Code #26426

merged 13 commits into from
Oct 18, 2023

Conversation

rjvelazco
Copy link
Contributor

@rjvelazco rjvelazco commented Oct 11, 2023 •
edited by ghost
Loading

Description

🤖 Generated by Copilot at 80968f2

This pull request adds a new component DotBinaryFieldEditorComponent that allows users to edit binary files with the Monaco code editor in the binary field type. It also modifies the DotBinaryFieldComponent and its related files to use the new component and improve the user experience and functionality.

Related Issue

Fixes #26045

Explanation of Changes

🤖 Generated by Copilot at 80968f2

  • Import and register MonacoEditorModule for the app (link, link)
  • Add dot-binary-field-editor component to render the editor and the form in the binary field component (link, link, link, link, link, link)
  • Prevent dialog from closing on escape key in the binary field component (link)
  • Simulate successful upload in the binary field component stories (link)
  • Add output event emitter for the temp file in the dot-binary-field-editor component (link)
  • Use view child reference for the editor component in the dot-binary-field-editor component (link)
  • Create form group for the form controls in the dot-binary-field-editor component (link, link)
  • Configure editor options and mime type in the dot-binary-field-editor component (link)
  • Implement OnInit and AfterViewInit hooks in the dot-binary-field-editor component (link)
  • Define methods for setting editor language, uploading file, updating editor options, and enabling and disabling editor in the dot-binary-field-editor component (link)
  • Add unit test for the dot-binary-field-editor component (link)
  • Add mock message for the save button label in the dot-binary-field-editor component (link)

Screenshots

Original Updated
** original screenshot ** ** updated screenshot **

@rjvelazco rjvelazco marked this pull request as ready for review October 16, 2023 15:40
@rjvelazco rjvelazco requested review from fmontes, zJaaal, oidacra, manuelrojas, hmoreras and KevinDavilaDotCMS and removed request for fmontes October 16, 2023 15:40
@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

0.0% 0.0% Security Hotspots Reviewed on New Code (is less than 100%)

See analysis details on SonarQube

@fmontes
Copy link
Member

fmontes commented Oct 18, 2023

Sonar Qube is broken.

@fmontes fmontes merged commit 15e5579 into master Oct 18, 2023
31 of 33 checks passed
@fmontes fmontes deleted the issue-26045-edit-contentlet-allow-user-write-code branch October 18, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdotcms jdotcms jdotcms left review comments

@zJaaal zJaaal zJaaal approved these changes

@fmontes fmontes fmontes approved these changes

@oidacra oidacra Awaiting requested review from oidacra

@manuelrojas manuelrojas Awaiting requested review from manuelrojas

@hmoreras hmoreras Awaiting requested review from hmoreras

@KevinDavilaDotCMS KevinDavilaDotCMS Awaiting requested review from KevinDavilaDotCMS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit Contentlet: Allow User Write Code
4 participants
@rjvelazco @fmontes @jdotcms @zJaaal