Fix #26163: Edit Contentlet implement Feature Flag #26242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of jsp old dialog
…//github.com/dotCMS/core into 26163-edit-contentlet-implement-feature-flag
This reverts commit d9a3f9f.
…et from edit page
…d and verify content types
fmontes
approved these changes
Oct 2, 2023
core-web/libs/data-access/src/lib/dot-properties/dot-properties.service.ts
Outdated
Show resolved
Hide resolved
core-web/libs/data-access/src/lib/dot-properties/dot-properties.service.ts
Outdated
Show resolved
Hide resolved
fmontes
requested changes
Oct 2, 2023
core-web/apps/dotcms-ui/src/app/api/services/guards/edit-content.guard.ts
Outdated
Show resolved
Hide resolved
|
SonarQube Quality Gate
|
|
SonarQube Quality Gate
|
fmontes
approved these changes
Oct 2, 2023
manuelrojas
pushed a commit
that referenced
this pull request
Oct 5, 2023
#26242) * dev (general): add new library and route * dev (configuration resource Java): Add Feature Flags to WhiteList * copywritting (edit-content routing): change name to match standard * dev (edit content guard): add guard to prevent navigation without feature flag * dev (app routing): add guard to edit content and move pages route to angular * fix (general): add guard to providers and fix bad use of inject * dev (custom event handler): add feature flag to redirect to new form instead of jsp old dialog * fix (general test): test were broken by bad import in providers * fix (form component test): missing import * dev (general): add routing for creating contentlet * dev (dot custom event handler): add re routing for edit task * dev (dot pages store): add redirect to new portlet when feature flag is on * fix (pages portlet): some tests were broken * dev (dot edit page nav): Add redirect to new edit contentlet * fix (pages create dialog): route were wrong * Revert "dev (dot edit page nav): Add redirect to new edit contentlet" This reverts commit d9a3f9f. * dev (jsp): add contentType to event * dev (dot custom event handler service): add event for create contentlet from edit page * dev (general): final replace of the route to content * dev (general): solve feedback * feedback (edit content guard): change the approach to be functional guard * feedback (general): add tests and small refactor * feedback (general): small refactor * feedback (feature flags): fix content editor 2 value * dev (dot properties service): add methods to get feature flags values directly * dev (jsp): edit redirects now sends the content type in the event * dev (host jsp): now host emits a different event to go to legacy portlet * dev (custom event handler): refactor to handle new feature flag method and verify content types * fix (custom event handler): tests were broken * fix (dot properties service): Add missing done callback * dev (general): apply refactor for new feature flag method * fix (dot feature flag resolver): test were broken * dev (dot pages): add redirect to new edit contentlet checking the content types * fix (pages store): fix tests * feedback (general): change name of methods * feedback (general): fix feature flag name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at a85ba15
Summary
🆕🛡️🔄
This pull request adds a new content editor feature that can be enabled or disabled by a feature flag. It creates a new library
edit-contentthat contains the routes and components for the new editor. It also updates the existing components and services that interact with the content editor to handle the routing and the feature flag logic. It adds tests and configuration files for the new library and the modified components and services. It modifies theshared-models.tsfile to add new keys for the feature flag values.Walkthrough
EditContentGuardservice to check feature flag for new content editor route (link, link, link, link, link, link)DotPropertiesServicetoDotPageStoreandDotCustomEventHandlerServiceto get feature flag value (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)isContentEditor2Enabledproperty toDotPagesStateandDotPageStoredata (link, link, link, link, link, link, link, link, link, link, link, link)isContentEditor2Enabledproperty toDynamicDialogConfigdata forDotPagesCreatePageDialogComponent(link, link, link)DotCustomEventHandlerServiceto handle routing for new content editor (link, link, link, link, link, link, link, link)DotPageStoreto handle routing for new content editor (link, link, link, link, link, link, link)DotPagesCreatePageDialogComponentto handle routing for new content editor (link, link, link)edit-contentlibrary with routes and shell component for new content editor (link, link, link, link, link, link, link)FEATURE_FLAG_CONTENT_EDITOR2_ENABLEandFEATURE_FLAG_CONTENT_EDITOR2_CONTENT_TYPEkeys toFeaturedFlagsenum (link)Screenshots
Screen.Recording.2023-09-26.at.5.06.59.PM-2.mov
Entry Points Covered
Content search
Pages
Site browser
Tasks