Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotCMS Fields: create a contenttype fields library #25786

Merged

Conversation

rjvelazco
Copy link
Contributor

@rjvelazco rjvelazco commented Aug 15, 2023

Proposed Changes

  • Create a library for contenttype fields

Description

🤖 Generated by Copilot at 4a2fc10

This pull request adds two new apps to the core-web project: contenttype-fields-builder and contenttype-fields-builder-e2e. The former is an Angular app that allows creating and editing custom contenttype fields components, and the latter is a Cypress app that provides end-to-end testing for the former. The pull request also updates the pre-commit hook script to exclude these apps from the linting target, and adds the necessary configuration files for ESLint, Cypress, Nx, Jest, and TypeScript for both apps.

Related Issue

Fixes #25781

Explanation of Changes

🤖 Generated by Copilot at 4a2fc10

  • Exclude new apps from linting target in pre-commit hook script (link)
  • Add ESLint configuration file with Angular overrides (link)
  • Add Jest configuration file with Angular and jest-preset-angular options (link)
  • Add Nx project configuration file with build, serve, i18n, lint, and test targets (link)
  • Add app component with app title (link)
  • Add app component test file with basic test cases (link)
  • Add app module file that bootstraps app component and registers custom elements (link)
  • Add index HTML file with app root component (link)
  • Add ESLint configuration file with Cypress overrides (link)
  • Add Cypress configuration file with folder and runner options (link)
  • Add Nx project configuration file with e2e and lint targets and dependency on contenttype-fields-builder app (link)
  • Add sample fixture file with mock data (link)
  • Add sample integration test file with simple test case (link)
  • Add plugins file with TypeScript preprocessing (link)
  • Add helper function file to get greeting element (link)
  • Add custom commands file with login command (link)
  • Add support file that imports custom commands file (link)
  • Add TypeScript configuration file with Cypress and Angular types and compiler options (link)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjvelazco it is looks like the Front-End checks are failing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@rjvelazco rjvelazco changed the title dotCMS Fields: create a web components library dotCMS Fields: create a contenttype fields library Aug 16, 2023
@@ -11,7 +11,8 @@ module.exports = {
'../src/**/*.stories.mdx',
'../src/**/*.stories.@(js|jsx|ts|tsx)',
'../../../libs/template-builder/**/*.stories.@(js|jsx|ts|tsx|mdx)',
'../../../libs/block-editor/**/*.stories.@(js|jsx|ts|tsx|mdx)'
'../../../libs/block-editor/**/*.stories.@(js|jsx|ts|tsx|mdx)',
'../../../libs/contenttype-fields/**/*.stories.@(js|jsx|ts|tsx|mdx)'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fmontes fmontes merged commit 6f631c9 into master Aug 16, 2023
@fmontes fmontes deleted the issue-25781-dotcms-fields-create-a-web-components-library branch August 16, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit Contentlet: create a contenttype fields library
5 participants