Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Content: Explore the possibility to use web components for fields #25581

Conversation

rjvelazco
Copy link
Contributor

@rjvelazco rjvelazco commented Jul 20, 2023

Description

🤖 Generated by Copilot at 2c73542

This pull request adds two new apps to the core-web project: contenttype-fields-builder and contenttype-fields-builder-e2e. The former is an app that builds web components for content type fields using angular elements, and the latter is an app that tests the former using cypress. The pull request adds the configuration, source, and test files for both apps, as well as the eslint and typescript rules.

Related Issue

Fixes #25434

Explanation of Changes

🤖 Generated by Copilot at 2c73542

  • Add two new apps for end-to-end testing and web component building of content type fields (link-link, link-link)
  • Create configuration files for nx workspace, eslint, typescript, karma, and cypress for each app (link, link, link, link, link, link, link, link, link)
  • Create entry point files for each app, such as index.html, main.ts, and app.module.ts (link, link, link)
  • Import the ContenttypeFieldsModule from the @dotcms/contenttype-fields library and define custom elements for web components in the contenttype-fields-builder app (link)
  • Create sample test and fixture files for the contenttype-fields-builder-e2e app, using cypress commands and helpers (link, link)
  • Create helper and plugin files for the contenttype-fields-builder-e2e app, such as app.po.ts, commands.ts, and index.js (link, link, link, link)

@rjvelazco rjvelazco marked this pull request as ready for review July 26, 2023 13:37
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this have jest tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right! I'll change it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

Copy link
Contributor

@zJaaal zJaaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit Content: Explore the posibility to use web components for fields
3 participants