Fix #25251: Favorite Pages Reload Listing when Deactivating Router Outlet

[zJaaal]

🤖 Generated by Copilot at febfecd

Summary

🔧🧹🚚

Refactored the dot-pages component to remove the dependency on the contentlet dialog component and improve the performance and readability of the code. Simplified the router-outlet component and the tests for the dot-pages component.

Oh we're the coders of the dot-pages
We make it simple and we make it fast
We don't need contentlet or shutdown
We just reload when the route is past

Walkthrough

• Simplify router-outlet component in dot-pages template to only handle deactivate event (link)
• Remove unused import of Subscription type from dot-pages component file (link)
• Remove unused import of DotCreateContentletComponent from dot-pages component file and spec file (link, link)
• Remove contentletDialogShutdown property and related methods from dot-pages component class (link, link)
• Add loadPagesOnDeactivation method to dot-pages component class to call getPages method of store service (link)
• Remove test case for getting pages after closing DotCreateContentletComponent from dot-pages component spec file (link)
• Modify test case for deactivating router-outlet to check that getPages method is called from dot-pages component spec file (link)

Screenshots

Screen.Recording.2023-07-14.at.1.15.49.PM.mov

Note

The ideal behavior would be that we reload the listing only when we execute a workflow and not everytime we close the edit-content dialog. We can work in the enhancement of the workflows events in this issue EPIC: Content Edit Refactor & Refresh#25445