-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail gracefully when OpenAI model stops working #29284
Closed
Tracked by
#28813
victoralfaro-dotcms opened this issue
Jul 18, 2024
· 4 comments
· Fixed by #29748, #29761, #29774 or #29806
Closed
Tracked by
#28813
Fail gracefully when OpenAI model stops working #29284
victoralfaro-dotcms opened this issue
Jul 18, 2024
· 4 comments
· Fixed by #29748, #29761, #29774 or #29806
Comments
victoralfaro-dotcms
moved this from New
to Next 1-3 Sprints
in dotCMS - Product Planning
Jul 18, 2024
john-thomas-dotcms
moved this from Next 1-3 Sprints
to Current Sprint Backlog
in dotCMS - Product Planning
Jul 24, 2024
victoralfaro-dotcms
moved this from Current Sprint Backlog
to In Progress
in dotCMS - Product Planning
Jul 30, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 30, 2024
…29236) Removing hardcoded OpenAI models at enum class OpenAIModel. Instead they are now part of the `dotAI.yml` application descriptor so the user can be the one who configures them not only one but multiple models for `text`, `image` and `embeddings`. The way to specify more than one is to provide a comma delimited list in the new dotAI App params. Sometimes we accept a model to use in the payload of our AI endpoints, for this matter we will validate that model and if it's invalid we will throw an exception. When is not present in the payload, then our backend will inject the current model. Which leads us to the question: How will the current model be determined? This is part of the work defined for #29284 (model fallback)
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 2, 2024
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 9, 2024
…o AI Provider (OpenAI) Refs: #29284
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 10, 2024
…o AI Provider (OpenAI) Refs: #29284
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 16, 2024
…o AI Provider (OpenAI) Refs: #29284
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 20, 2024
…o AI Provider (OpenAI) Refs: #29284
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 22, 2024
…o AI Provider (OpenAI) Refs: #29284
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 22, 2024
…o AI Provider (OpenAI) Refs: #29284
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 22, 2024
…o AI Provider (OpenAI) Refs: #29284
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 22, 2024
…o AI Provider (OpenAI) Refs: #29284
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 22, 2024
…o AI Provider (OpenAI) Refs: #29284
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 22, 2024
…o AI Provider (OpenAI) Refs: #29284
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 22, 2024
…o AI Provider (OpenAI) Refs: #29284
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 23, 2024
…o AI Provider (OpenAI) Refs: #29284
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 28, 2024
Removing `OpenAIRequest` class in favor of set of classes explainied in `src/main/java/com/dotcms/ai/client/README.md` and integrating it with the corresponding consuming components. Integration tests added/updated. Refs: #29284
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 28, 2024
Removing `OpenAIRequest` class in favor of set of classes explainied in `src/main/java/com/dotcms/ai/client/README.md` and integrating it with the corresponding consuming components. Integration tests added/updated. Refs: #29284
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 28, 2024
Removing `OpenAIRequest` class in favor of set of classes explainied in `src/main/java/com/dotcms/ai/client/README.md` and integrating it with the corresponding consuming components. Integration tests added/updated. Refs: #29284
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 28, 2024
Removing `OpenAIRequest` class in favor of set of classes explainied in `src/main/java/com/dotcms/ai/client/README.md` and integrating it with the corresponding consuming components. Integration tests added/updated. Refs: #29284
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 28, 2024
Removing `OpenAIRequest` class in favor of set of classes explainied in `src/main/java/com/dotcms/ai/client/README.md` and integrating it with the corresponding consuming components. Integration tests added/updated. Refs: #29284
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 29, 2024
Removing `OpenAIRequest` class in favor of set of classes explainied in `src/main/java/com/dotcms/ai/client/README.md` and integrating it with the corresponding consuming components. Integration tests added/updated. Refs: #29284
QA NotesConfigure a dotAI application using a valid key:
Reset DB for embeddings
dotAI Portlet:Go to the
|
victoralfaro-dotcms
moved this from In Progress
to In Review
in dotCMS - Product Planning
Aug 30, 2024
victoralfaro-dotcms
moved this from In Review
to Internal QA
in dotCMS - Product Planning
Aug 30, 2024
victoralfaro-dotcms
added a commit
that referenced
this issue
Aug 30, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 30, 2024
Applying missing feedback
INTERNAL QA: PASSED
The expected results and error messages described in Victor's comment are showing up as expected. Now, its VERY IMPORTANT that, in some scenarios, you reset the DotAI configuration as Victor said:
Otherwise, you may not get the expected result in the scenario. |
github-project-automation
bot
moved this from QA - Backlog
to Internal QA
in dotCMS - Product Planning
Sep 3, 2024
Approved: Tested on trunk_e622545, Docker, macOS 14.5, FF v126.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Parent Issue
#28813
User Story
As a Java developer, I want to provide a fallback strategy for when our OpenAI client fails. We need to identify the cause of the failure due to three main reasons:
The fallback strategy consists of the following steps:
Acceptance Criteria
dotCMS Version
master
Proposed Objective
Core Features
Proposed Priority
Priority 2 - Important
External Links... Slack Conversations, Support Tickets, Figma Designs, etc.
to_define
Assumptions & Initiation Needs
Quality Assurance Notes & Workarounds
The text was updated successfully, but these errors were encountered: