Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UVE: Contentlets created on variants are not saving correctly #28799

Closed
zJaaal opened this issue Jun 7, 2024 · 13 comments · Fixed by #30556
Closed

UVE: Contentlets created on variants are not saving correctly #28799

zJaaal opened this issue Jun 7, 2024 · 13 comments · Fixed by #30556

Comments

@zJaaal
Copy link
Contributor

zJaaal commented Jun 7, 2024

Problem Statement

After creating a contentlet inside a variant we have different issues with the contentlet:

Image not showing on HTML but is showing on Content Palette:

Screenshot 2024-06-07 at 11 12 42 AM

Unable to open Edit Contentlet:

Screen.Recording.2024-06-06.at.6.01.45.PM.mov

We can open the edit content in the old edit mode, but the image is not saved:

Screen.Recording.2024-06-07.at.11.34.38.AM.mov

Steps to Reproduce

  1. Configure and run the Analytics app
  2. Enable the UVE for your environment
  3. Create an experiment for any page
  4. Create a variant
  5. Go to that variant
  6. Create a contentlet and use it
  7. Click to edit the recently created contentlet
  8. See the error

Acceptance Criteria

We should be able to create, edit and reuse a contentlet inside a variant

dotCMS Version

trunk-latest

Proposed Objective

Technical User Experience

Proposed Priority

Priority 2 - Important

Assumptions & Initiation Needs

  1. You understand how to use the UVE
  2. You understand how experiments work

Quality Assurance Notes & Workarounds

No workarounds at the moment.

@fmontes
Copy link
Member

fmontes commented Jun 7, 2024

@freddyDOTCMS will be checking the backend.

@freddyDOTCMS
Copy link
Contributor

I am almost sure this is a Backend issue, also it is part of the Experiment changes so I am going to take to Falcon Team

@jcastro-dotcms
Copy link
Contributor

jcastro-dotcms commented Sep 9, 2024

As per conversation with @john-thomas-dotcms and @freddyDOTCMS on August 28th, 2024, this issue is not caused by Java/back-end code, but the Angular layer.

Slack thread: https://dotcms.slack.com/archives/CQMHM7PNJ/p1724882036153449

@john-thomas-dotcms
Copy link
Contributor

@freddyDOTCMS can you please put details in this card about your investigation, and let us know if you think this should be handled by the UVE team or not?

@freddyDOTCMS
Copy link
Contributor

We are not cleaning up the current Variant when get out of an Experiment, in the image you can see the the Session Storage has the as current Variant the Experiment's Variant, even when I am on the Browser Portlet

image (6)

For example I go inside a Variant, the go out and create a Page, the age was created but inside the Experiment's Variant

it can be the root of all the problems that we have with Variant

@john-thomas-dotcms
Copy link
Contributor

@fmontes please see Freddy R's comment above.

Summary: The variant id is not being cleaned up when you got to edit a variant, and then stop editing the variant (going back to the experiments config).

We haven't touched this code in quite a while, so we think that probably happened during some UVE changes. And we'd like to make sure the UVE devs know how to handle experiments and variants since you're in this code quite a bit. So, can your team take on the fix?

@fmontes
Copy link
Member

fmontes commented Oct 31, 2024

@john-thomas-dotcms make sense, I'll take this back to Scout for further investigation and fix.

@zJaaal zJaaal moved this from Next 1-3 Sprints to In Progress in dotCMS - Product Planning Nov 1, 2024
@zJaaal zJaaal self-assigned this Nov 1, 2024
@zJaaal
Copy link
Contributor Author

zJaaal commented Nov 1, 2024

I found out something related to the session storage not being updated.
I'll be working on this and will notify the details of the fix that I will implement.

Thanks for the insights @john-thomas-dotcms @freddyDOTCMS @jcastro-dotcms

@zJaaal zJaaal linked a pull request Nov 1, 2024 that will close this issue
Copy link

github-actions bot commented Nov 1, 2024

@zJaaal zJaaal moved this from In Progress to In Review in dotCMS - Product Planning Nov 5, 2024
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Nov 8, 2024
@zJaaal zJaaal removed their assignment Nov 8, 2024
@zJaaal
Copy link
Contributor Author

zJaaal commented Nov 8, 2024

Note to QA

I recommend to test the edit contentlet in the site browser and the Query Tool.

You can get contentlets by variants in the Query Tool by using +variant:<your variant id> when you have results, you will be able to open the edit contentlet by clicking on the title, be sure to create content for variants inside the UVE first

@zJaaal zJaaal reopened this Nov 8, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Nov 8, 2024
@zJaaal zJaaal moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Nov 8, 2024
@zJaaal
Copy link
Contributor Author

zJaaal commented Nov 8, 2024

Note to QA

While investigating I found out that the broken image on variants, could be related to the container/content type code inside the VTL, so we probably need to create a ticket to update the starter or if there is one, make a change in the VTL code to support variants.

cc: @fmontes @nollymar @john-thomas-dotcms

@valentinogiardino valentinogiardino self-assigned this Nov 8, 2024
@valentinogiardino
Copy link
Contributor

IQA PASSED

Variant contentlets are working as expected.
Tested on dotcms/dotcms:trunk_b919bba.

Video

iqa-variant-passed.mp4
iqa-variant-passed-2.mp4

@bryanboza
Copy link
Member

bryanboza commented Nov 20, 2024

We can pass this for now, but we reported two new issues in this functionality #30726 && #30727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants