Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Page V2: Content Palette is not querying content for the current variant #28656

Closed
zJaaal opened this issue May 23, 2024 · 6 comments · Fixed by #28766
Closed

Edit Page V2: Content Palette is not querying content for the current variant #28656

zJaaal opened this issue May 23, 2024 · 6 comments · Fixed by #28766

Comments

@zJaaal
Copy link
Contributor

zJaaal commented May 23, 2024

Parent Issue

TBD

Problem Statement

We need to query the content created for an specific variant. Right now if we create content for a variant we cannot use it from the Content Palette.

Actual query: "+contentType:{contentTypeVar} +deleted: false +languageId : 1 "

It should also contain: +variant: {current variant} OR DEFAULT

Steps to Reproduce

  1. Configure the UVE to run for VTL Pages
  2. Configure Experiments
  3. Go to a page
  4. Open Experiments and create a new experiment
  5. Create a Variant and hit edit
  6. Create a contentlet from the UVE in a variant
  7. Search for that contentlet inside the palette
  8. See the error
Screen.Recording.2024-05-23.at.4.33.57.PM.mov

Acceptance Criteria

  • We should be able to see contetlets created for an specific variant inside the palette
  • UVE should work as expected for this contentlets

dotCMS Version

trunk-latest

Proposed Objective

Technical User Experience

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

  • You understand how variants work
  • You understand how the UVE work

Quality Assurance Notes & Workarounds

No workarounds at the moment

Sub-Tasks & Estimates

No response

@zJaaal zJaaal moved this from New to Current Sprint Backlog in dotCMS - Product Planning May 23, 2024
@zJaaal zJaaal moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Jun 5, 2024
@zJaaal zJaaal self-assigned this Jun 5, 2024
@zJaaal zJaaal linked a pull request Jun 5, 2024 that will close this issue
@zJaaal zJaaal moved this from In Progress to In Review in dotCMS - Product Planning Jun 5, 2024
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Jun 6, 2024
@KevinDavilaDotCMS
Copy link
Contributor

IQ Failed

The functionality of contentlets inside variants works

IQA.Passed.with.errors.mov

But we cannot edit that contentlets in the UVE

Screen.Recording.2024-06-06.at.6.01.45.PM.mov

Maybe this error can be fixed in other ticket

@zJaaal
Copy link
Contributor Author

zJaaal commented Jun 7, 2024

We will revisit this issue in this ticket #28799

@fmontes fmontes moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Jun 7, 2024
@josemejias11 josemejias11 self-assigned this Jun 11, 2024
@josemejias11 josemejias11 moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Jun 11, 2024
@josemejias11
Copy link
Contributor

Failed: Tested on trunk_85dce97, Docker, macOS 14.5, FF v126.0.1

When trying to add the same content to the variant, the contentlets should close and show the message of the content is already added to the contentlets. Currently we need to close the popup window to show the message.

Screen.Recording.2024-06-11.at.3.53.40.PM.mov

@josemejias11 josemejias11 reopened this Jun 11, 2024
@github-project-automation github-project-automation bot moved this from QA - In Progress to Current Sprint Backlog in dotCMS - Product Planning Jun 11, 2024
@zJaaal
Copy link
Contributor Author

zJaaal commented Jun 12, 2024

@josemejias11 I'm not sure if that issue is related to this one #28799 but it is not related to the work done in this issue, we only wanted to show the contentlets created in variants on the content palette, the contentlet selector was not modified in this ticket.

We should raise another ticket for it if is not related to the one I mentioned above

@fmontes
Copy link
Member

fmontes commented Jun 12, 2024

100% another ticket

@fmontes fmontes moved this from Current Sprint Backlog to QA - Backlog in dotCMS - Product Planning Jun 12, 2024
@bryanboza bryanboza moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Jun 12, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on trunk_6d0d4a5, Docker, macOS 14.5, FF v126.0.1

Feedback will be addressed in card #28870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment