Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Contentlet Redesign: Create New Binary Field Feature Flag #26219

Closed
Tracked by #25445
rjvelazco opened this issue Sep 21, 2023 · 3 comments · Fixed by #26259
Closed
Tracked by #25445

Edit Contentlet Redesign: Create New Binary Field Feature Flag #26219

rjvelazco opened this issue Sep 21, 2023 · 3 comments · Fixed by #26259
Assignees
@rjvelazco
Labels
OKR : User Experience Owned by Jason Priority : 3 Average QA : Approved Team : Lunik Type : Task

Comments

@rjvelazco
Copy link
Contributor

rjvelazco commented Sep 21, 2023 •
edited
Loading

Parent Issue

#25445

Task

Create a FEATURE_FLAG_NEW_BINARY_FIELD feature falg and add the new binary field component to the .jsp file.

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

Acceptance Criteria

When the feature flag is enabled, the new binary field should be visible. However, when the feature flag is disabled, the current binary field should be visible instead.

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@rjvelazco rjvelazco self-assigned this Sep 21, 2023
@rjvelazco rjvelazco mentioned this issue Sep 21, 2023
Open
@rjvelazco rjvelazco moved this from New to Current Sprint Backlog in dotCMS - Product Planning Sep 21, 2023
@fmontes fmontes moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Sep 22, 2023
@fmontes fmontes mentioned this issue Sep 26, 2023
Closed
@rjvelazco rjvelazco linked a pull request Sep 27, 2023 that will close this issue
Edit Contentlet: Implement feature flag #26259
Merged
@rjvelazco rjvelazco mentioned this issue Sep 27, 2023
Merged
@rjvelazco rjvelazco moved this from In Progress to In Review in dotCMS - Product Planning Sep 27, 2023
fmontes pushed a commit that referenced this issue Sep 28, 2023
@rjvelazco
chore(edit-content): Edit Contentlet Redesign: Create New Binary Fiel…
40f56af 
…d Feature Flag fix #26219

* dev: implement New Binary Field Feature Flag

* dev: add conditional to handle empy feature flag

* dev: improve variable naming

* dev: build binary-field
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Sep 28, 2023
@fmontes fmontes moved this from Done to Internal QA in dotCMS - Product Planning Sep 28, 2023
@fmontes fmontes moved this from Internal QA to Done in dotCMS - Product Planning Oct 2, 2023
@rjvelazco
Copy link
Contributor Author

@fmontes Is the feature flag not working? If so, is there any specific steps to reproduce?

@fmontes fmontes moved this from Done to Internal QA in dotCMS - Product Planning Oct 3, 2023
@fmontes fmontes removed the Needs Work label Oct 3, 2023
manuelrojas pushed a commit that referenced this issue Oct 5, 2023
@rjvelazco @manuelrojas
chore(edit-content): Edit Contentlet Redesign: Create New Binary Fiel…
142f486 
…d Feature Flag fix #26219

* dev: implement New Binary Field Feature Flag

* dev: add conditional to handle empy feature flag

* dev: improve variable naming

* dev: build binary-field
@KevinDavilaDotCMS
Copy link
Contributor

Pass internal QA

Tested in master

Screen.Recording.2023-10-09.at.12.44.59.mov

@KevinDavilaDotCMS KevinDavilaDotCMS moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Oct 9, 2023
@bryanboza bryanboza moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Oct 10, 2023
@josemejias11 josemejias11 reopened this Oct 10, 2023
@github-project-automation github-project-automation bot moved this from QA - In Progress to Current Sprint Backlog in dotCMS - Product Planning Oct 10, 2023
@bryanboza bryanboza moved this from Current Sprint Backlog to QA - In Progress in dotCMS - Product Planning Oct 10, 2023
@josemejias11
Copy link
Contributor

Approved: Tested on master_efcccfc_SNAPSHOT, Docker, macOS 13.0, FF v113.0

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Oct 10, 2023
@fmontes fmontes closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjvelazco rjvelazco

Labels
OKR : User Experience Owned by Jason Priority : 3 Average QA : Approved Team : Lunik Type : Task
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Edit Contentlet: Implement feature flag dotCMS/core
7 participants
@fmontes @bryanboza @victoralfaro-dotcms @rjvelazco @damen-dotcms @josemejias11 @KevinDavilaDotCMS