Skip to content

Commit

Permalink
fix(CICD): Removing extra line from the list of returned tags (#28935)
Browse files Browse the repository at this point in the history
Refs: #28934

### Proposed Changes
The value returned for the list of docker tags was new line separated
causing the json message to break when it was inserted.
  • Loading branch information
nollymar authored Jun 18, 2024
1 parent 2a9ba6b commit f319f84
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions .github/actions/deploy-artifact-docker/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ inputs:
outputs:
tags:
description: "The tags that were used to build the image"
value: ${{ steps.meta.outputs.tags }}
value: ${{ steps.convert_tags.outputs.space_separated_tags }}
runs:
using: "composite"
steps:
Expand All @@ -87,7 +87,6 @@ runs:
tar -xvf docker-build.tar -C ${CONTEXT_TMP_PATH}
echo "docker_context=${CONTEXT_TMP_PATH}" >> $GITHUB_OUTPUT
fi
shell: bash
- name: Set Common Vars
shell: bash
Expand Down Expand Up @@ -131,7 +130,6 @@ runs:
echo "type=raw,value=${RESULT},enable=true" >> $GITHUB_ENV
echo "type=raw,value=latest,enable=${enable_latest}" >> $GITHUB_ENV
echo "EOF" >> $GITHUB_ENV
- name: Docker.io login
uses: docker/[email protected]
with:
Expand Down Expand Up @@ -162,6 +160,11 @@ runs:
tags: ${{ env.FULL_TAGS_OUTPUT }}
if: success()

- name: Convert tags to space-separated string
id: convert_tags
shell: bash
run: echo "space_separated_tags=$(echo '${{ steps.meta.outputs.tags }}' | tr '\n' ' ')" >> $GITHUB_OUTPUT

- name: Debug Docker Metadata
shell: bash
run: |
Expand All @@ -177,9 +180,6 @@ runs:
platforms: ${{ inputs.docker_platforms }}
driver-opts: |
image=moby/buildkit:v0.12.2
- name: Build/Push Docker Image
uses: docker/build-push-action@v5
with:
Expand Down

0 comments on commit f319f84

Please sign in to comment.