Skip to content

Commit

Permalink
fix(CICD): Add Slack notification step to dotCLI release (#28673) (#2…
Browse files Browse the repository at this point in the history
…8797)

### Proposed Changes
* Removing slack notification conditional.  

### Additional Info
Related to #28673 (CICD Add Slack notification step to dotCLI release).

---------

Co-authored-by: Daniel Colina <[email protected]>
  • Loading branch information
dcolina and dcolina authored Jun 10, 2024
1 parent 97fed9e commit d36fe1f
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/cli-release-process.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ on:
description: 'Release version'
default: '1.0.0-SNAPSHOT'
required: false
notify_slack:
description: 'Notify Slack'
default: 'true'
required: false

concurrency:
group: ${{ github.workflow }}-${{ github.ref || github.run_id }}
Expand Down Expand Up @@ -465,6 +461,7 @@ jobs:
npm publish --access public --tag ${NPM_PACKAGE_VERSION_TAG}
- name: Slack Notification
continue-on-error: true
uses: rtCamp/action-slack-notify@v2
env:
SLACK_WEBHOOK: ${{ secrets.RELEASE_SLACK_WEBHOOK }}
Expand All @@ -475,7 +472,6 @@ jobs:
MSG_MINIMAL: true
SLACK_FOOTER: ""
SLACK_ICON: https://avatars.slack-edge.com/temp/2021-12-08/2830145934625_e4e464d502865ff576e4.png
if: success() && github.event.inputs.notify_slack == 'true'

clean-up:
name: "Clean Up"
Expand Down

0 comments on commit d36fe1f

Please sign in to comment.