Skip to content

Commit

Permalink
#30367 Applying code review feedback.
Browse files Browse the repository at this point in the history
  • Loading branch information
jgambarios committed Dec 4, 2024
1 parent fdb6134 commit 81e1c04
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,8 @@ public JobPaginatedResult getCompletedJobs(int page, int pageSize) throws DotDat

@CloseDBIfOpened
@Override
public JobPaginatedResult getSuccessfulJobs(int page, int pageSize) throws DotDataException {
public JobPaginatedResult getSuccessfulJobs(final int page, final int pageSize)
throws DotDataException {
try {
return jobQueue.getSuccessfulJobs(page, pageSize);
} catch (JobQueueDataException e) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -428,10 +428,9 @@ public static Predicate<Job> hasFailed() {
}

/**
* Creates a predicate that matches successful jobs. The predicate matches any job in the
* SUCCESS state.
* Creates a predicate that matches any completed job.
*
* @return A predicate for matching successful jobs
* @return A predicate for matching completed jobs
*/
public static Predicate<Job> isCompleted() {
return job -> (job.state() == JobState.SUCCESS
Expand Down

0 comments on commit 81e1c04

Please sign in to comment.