fix(block-editor): Fix Open link in new window checkbox in the block …

…editor. Don't save the selection. #25842

* Fixed target on link url in block editor - images

* Resolved comments on PR

core-web/libs/block-editor/src/lib/extensions/bubble-link-form/plugins/bubble-link-form.plugin.ts

@@ -185,12 +185,16 @@ export class BubbleLinkFormView {
     }
 
     setLinkValues({ link, blank = false }) {
-        if (link.length > 0) {
-            const href = this.formatLink(link);
-            this.isImageNode()
-                ? this.editor.commands.setImageLink({ href })
-                : this.editor.commands.setLink({ href, target: blank ? '_blank' : '_top' });
+        if (!link.length) {
+            return;
         }
+
+        const href = this.formatLink(link);
+        const linkValue = { href, target: blank ? '_blank' : '_top' };
+
+        this.isImageNode()
+            ? this.editor.commands.setImageLink(linkValue)
+            : this.editor.commands.setLink(linkValue);
     }
 
     removeLink() {
@@ -239,10 +243,10 @@ export class BubbleLinkFormView {
     }
 
     getLinkProps(): NodeProps {
-        const { href: link = '', target } = this.editor.isActive('link')
+        const { href: link = '', target = '_top' } = this.editor.isActive('link')
             ? this.editor.getAttributes('link')
             : this.editor.getAttributes(ImageNode.name);
-        const blank = target ? target === '_blank' : true;
+        const blank = target === '_blank';
 
         return { link, blank };
     }

core-web/libs/block-editor/src/lib/nodes/image-node/helpers/index.ts

@@ -7,9 +7,9 @@ import { DotCMSContentlet } from '@dotcms/dotcms-models';
 const LANGUAGE_ID = 'language_id';
 
 export const imageLinkElement = (attrs, newAttrs): DOMOutputSpec => {
-    const { href = null } = newAttrs;
+    const { href = null, target } = newAttrs;
 
-    return ['a', { href }, imageElement(attrs, newAttrs)];
+    return ['a', { href, target }, imageElement(attrs, newAttrs)];
 };
 
 export const imageElement = (attrs, newAttrs): DOMOutputSpec => {

core-web/libs/block-editor/src/lib/nodes/image-node/image.node.ts

@@ -10,7 +10,7 @@ declare module '@tiptap/core' {
             /**
              * Set Image Link mark
              */
-            setImageLink: (attributes: { href: string }) => ReturnType;
+            setImageLink: (attributes: { href: string; target?: string }) => ReturnType;
             /**
              * Unset Image Link mark
              */
@@ -62,6 +62,11 @@ export const ImageNode = Image.extend({
                 default: null,
                 parseHTML: (element) => element.getAttribute('data'),
                 renderHTML: (attributes) => ({ data: JSON.stringify(attributes.data) })
+            },
+            target: {
+                default: null,
+                parseHTML: (element) => element.getAttribute('target'),
+                renderHTML: (attributes) => ({ target: attributes.target })
             }
         };
     },